Avoid checking deprecated optinos for OpenSSH >=7.6#110
Merged
Conversation
Member
Author
frederikbosch
approved these changes
Aug 1, 2018
frederikbosch
left a comment
frederikbosch
left a comment
There was a problem hiding this comment.
The approach looks good to me. The main issue here is how to be sure that we parse the output of ssh -V correctly across different operating systems. This seems correct for Ubuntu, my own OS. Hopefully this works for the others too.
E.g. on Ubuntu 18.04 SSH protocol version 1 was removed from OpenSSH 7.6: - https://www.openssh.com/txt/release-7.6 - https://www.openssh.com/txt/release-7.5 Signed-off-by: Artem Sidorenko <artem@posteo.de>
artem-sidorenko
force-pushed
the
ubuntu-18
branch
from
9c64ca2 to
5702120
Compare
artem-sidorenko
changed the title
Member
Author
|
@frederikbosch thanks! I tested it with test-kitchen from chef-os-hardening on all supported platforms, it looks good |
chris-rock
approved these changes
Aug 1, 2018
Member
chris-rock
left a comment
chris-rock
left a comment
There was a problem hiding this comment.
Great improvement @artem-sidorenko
| command('ssh').exist? | ||
| end | ||
|
|
||
| ssh_version = command('ssh -V 2>&1 | cut -f1 -d" " | cut -f2 -d"_"').stdout.to_f |
Member
There was a problem hiding this comment.
Should we do this in a resource, so that we could reuse it for other test too in the future?
Member
Author
There was a problem hiding this comment.
Lets do it once we need it?
This was referenced Aug 2, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. on Ubuntu 18.04
Signed-off-by: Artem Sidorenko artem@posteo.de