Secret support for run-user-commands& up commands#493
Merged
Conversation
chrmarti
previously requested changes
Apr 17, 2023
chrmarti
left a comment
chrmarti
left a comment
Contributor
There was a problem hiding this comment.
Looks great, only one question. :)
joshspicer
reviewed
Apr 17, 2023
joshspicer
reviewed
Apr 17, 2023
joshspicer
reviewed
Apr 17, 2023
joshspicer
reviewed
Apr 17, 2023
…g/secrets-support-1
alexdima
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secret support for
run-user-commands&upcommands.A json file containing secrets can be passed in via a command line argument
--secrets-file.Secrets will be applied similar to
remoteEnvFile format:
{ "SECRET_NAME": "value" }Special handling for the secrets such as masking them from logs is not in scope for this PR.
Details of the spec is here (In Review)=> devcontainers/spec#224