Proposal: First class secrets support in dev containers implementations#224
Merged
Merged
Conversation
joshspicer
reviewed
Apr 13, 2023
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
chrmarti
previously requested changes
Apr 14, 2023
eljog
changed the title
chrmarti
reviewed
Apr 17, 2023
AlainGama
approved these changes
Apr 17, 2023
samruddhikhandale
approved these changes
Apr 25, 2023
samruddhikhandale
left a comment
samruddhikhandale
left a comment
Member
There was a problem hiding this comment.
Left a minor spelling comment, but besides that LGTM.
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
alexdima
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formal proposal based on #219
This proposal do not change the devcontainers spec itself, rather it is a proposal on the implementation of secrets support in supporting tools such as the devcontainers CLI (which could serve as a potential reference implementation)