Helpers and keywords unification#75
Conversation
|
I like the idea of always returning the full k8s object or list of objects for the mail keywords. When using the KubeLibrary I personally don't use any of the filter keywords and rather filter the k8s object myself in custom keywords. From my point of view the filter keywords are not needed. Having good test cases examples to build custom filters works better for me. My naming proposal would be to keep it close to the kubernetes api function names. e.g. |
|
@m-wcislo The changes look good. Good job. I really like the new filter keywords e.g. |
|
@Nilsty docs generted and release prepared, please approve. |
@Nilsty, @satish-nubolab, @mika-b - I'm planning to cleanup the keywords and helpers a little bit to make whole thing more DRY, clean etc. The idea is to make all the keywords always return k8s objects not their names in some cases. To get names or anything more specific we should use helpers (filters).
The old functions will be marked deprecated and kept till v1.0.0. Let me know your thoughts (also keyword naming convention proposal are welcome). Currently the PR has minimal POC version to show how it would look like and what are the efforts.
Before merge following needs to be applied: