fix(health): remove blocking calls from checkhealth#13
Merged
Conversation
Removes get_targets() call (triggers xcodebuild -list) and list_swiftly_versions() from checkhealth. Both can block Neovim indefinitely. Users can run :SwiftTargets and :SwiftVersionInfo for that info. Also fixes vim.v.shell_error usage after vim.system():wait() calls in version_validator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2 (again — deeper root cause identified). The previous fix removed
xcode.list_schemes()but two other blocking calls remained: -target_manager.get_targets()→ internally runsxcodebuild -list -json(can hang indefinitely) -validator.list_swiftly_versions()→ runsswiftly list(can be slow). Fix: Removed both calls fromcheckhealthand replaced with informational hints pointing to:SwiftTargetsand:SwiftVersionInfo. Bonus fix:vim.v.shell_errordoesn't work aftervim.system():wait()calls — fixed all occurrences inversion_validator.luato useobj.codeinstead.