fix(lsp): add timeout to xcrun in find_sourcekit_lsp#14
Merged
Conversation
xcrun without a timeout can hang checkhealth for 5-10s on macOS when the Xcode Developer Directory cache is cold. Adds a 3s timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2 — deep audit of all shell calls triggered by
:checkhealth swift.\n\nThexcrun --find sourcekit-lspcall inlsp.find_sourcekit_lsp()had no timeout. On macOS,xcruncan block for 5–10 seconds when the Xcode Developer Directory cache is cold or when Xcode CLT is being initialized for the first time.\n\nThis call is triggered by:checkhealth swift→ LSP section →lsp.is_available()→find_sourcekit_lsp().\n\nFull audit of all shell calls in checkhealth:\n| Call chain | Timeout | Safe? |\n|---|---|---|\n|swift --version| 5s ✅ | ✅ |\n|xcrun --find sourcekit-lsp| none → now 3s | ✅ |\n|swift-format --version| 5s ✅ | ✅ |\n|target_manager.get_targets()| removed in #13 ✅ | ✅ |\n|swiftly list| removed in #13 ✅ | ✅ |