Skip to content

fix(ux): remove duplicate error logging in feature downloads#135

Merged
skevetter merged 2 commits into
mainfrom
fix/duplicate-feature-logs
Apr 25, 2026
Merged

fix(ux): remove duplicate error logging in feature downloads#135
skevetter merged 2 commits into
mainfrom
fix/duplicate-feature-logs

Conversation

@skevetter

@skevetter skevetter commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove duplicate error logging in processOCIFeature and processDirectTarFeature where log.Errorf was called immediately before returning the same error to callers
  • Demote to log.Debugf where the log message adds context beyond the error itself (e.g. featureId, OCI reference, destination path)
  • Remove log calls entirely where the message duplicates the error content
  • Also clean up the same pattern in downloadFeatureFromURL

Summary by CodeRabbit

Release Notes

  • Chores
    • Adjusted logging verbosity during feature acquisition, downshifting error-level messages to debug level for improved clarity in normal operation scenarios.

@netlify

netlify Bot commented Apr 25, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit ae02c0e
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69ed3e68cc24940008c8258f

@coderabbitai

coderabbitai Bot commented Apr 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3130a9c2-6025-43dc-bd23-2d670ad879b8

📥 Commits

Reviewing files that changed from the base of the PR and between bcdb2e0 and ae02c0e.

📒 Files selected for processing (1)
  • pkg/devcontainer/feature/features.go

📝 Walkthrough

Walkthrough

Reduces log severity levels for errors during feature acquisition flows in three functions: processOCIFeature, processDirectTarFeature, and downloadFeatureFromURL. Error handling and propagation remain unchanged; only logging levels are adjusted from error to debug or removed.

Changes

Cohort / File(s) Summary
Feature Logging Downshift
pkg/devcontainer/feature/features.go
Downgrades error-level logs to debug level for OCI reference parsing, image fetch, layer download, extraction failures, and tarball operations during feature acquisition. Removes one invalid-format error log entirely. Error handling and returns unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and specifically summarizes the main change: removing duplicate error logging in feature downloads, which aligns with the primary objective and changes throughout the affected functions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

processOCIFeature and processDirectTarFeature logged errors at Error
level AND returned the error, causing duplicate messages when callers
also display the returned error. Demote to Debugf where the log adds
context beyond the error (featureId, reference, destination), remove
entirely where the log duplicates the error content.
@skevetter
skevetter force-pushed the fix/duplicate-feature-logs branch from 7e1c805 to ae02c0e Compare April 25, 2026 22:21
@skevetter
skevetter merged commit bf5a96f into main Apr 25, 2026
47 checks passed
@skevetter
skevetter deleted the fix/duplicate-feature-logs branch April 25, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant