fix(ux): remove duplicate error logging in feature downloads#135
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughReduces log severity levels for errors during feature acquisition flows in three functions: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
processOCIFeature and processDirectTarFeature logged errors at Error level AND returned the error, causing duplicate messages when callers also display the returned error. Demote to Debugf where the log adds context beyond the error (featureId, reference, destination), remove entirely where the log duplicates the error content.
7e1c805 to
ae02c0e
Compare
Summary
processOCIFeatureandprocessDirectTarFeaturewherelog.Errorfwas called immediately before returning the same error to callerslog.Debugfwhere the log message adds context beyond the error itself (e.g. featureId, OCI reference, destination path)downloadFeatureFromURLSummary by CodeRabbit
Release Notes