Skip to content

fix(ux): remove duplicate error logging in feature downloads #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Apr 25, 2026
Merged

fix(ux): remove duplicate error logging in feature downloads #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28a87bd
fix(ux): remove duplicate error logging in feature downloads
skevetter Apr 25, 2026
ae02c0e
fix: break long log line to satisfy golines linter
skevetter Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions pkg/devcontainer/feature/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,36 +163,35 @@ func processOCIFeature(id string) (string, error) {

ref, err := name.ParseReference(id)
if err != nil {
log.Errorf("failed to parse OCI reference: error=%v, featureId=%s", err, id)
log.Debugf("failed to parse OCI reference: error=%v, featureId=%s", err, id)
return "", err
}

log.Debugf("fetching OCI image: reference=%s", ref.String())
img, err := remote.Image(ref, remote.WithAuthFromKeychain(authn.DefaultKeychain))
if err != nil {
err = image.SanitizeRegistryError(err)
log.Errorf("failed to fetch OCI image: error=%v, reference=%s", err, ref.String())
log.Debugf("failed to fetch OCI image: error=%v, reference=%s", err, ref.String())
return "", err
}

destFile := filepath.Join(featureFolder, "feature.tgz")
err = downloadLayer(img, id, destFile)
if err != nil {
log.Errorf("failed to download feature layer: error=%v, featureId=%s", err, id)
log.Debugf("failed to download feature layer: error=%v, featureId=%s", err, id)
return "", err
}

file, err := os.Open(destFile)
if err != nil {
log.Errorf("failed to open downloaded feature file: error=%v, file=%s", err, destFile)
return "", err
}
defer func() { _ = file.Close() }()

log.Debugf("extract feature: destination=%s", featureExtractedFolder)
err = extract.Extract(file, featureExtractedFolder)
if err != nil {
log.Errorf(
log.Debugf(
"failed to extract feature: error=%v, destination=%s",
err,
featureExtractedFolder,
Expand Down Expand Up @@ -358,7 +357,6 @@ func processDirectTarFeature(

downloadBase := id[strings.LastIndex(id, "/"):]
if !directTarballRegEx.MatchString(downloadBase) {
log.Errorf("invalid tarball filename format: filename=%s", downloadBase)
return "", fmt.Errorf(
"expected tarball name to follow 'devcontainer-feature-<feature-id>.tgz' format. Received '%s' ",
downloadBase,
Expand Down Expand Up @@ -386,14 +384,14 @@ func processDirectTarFeature(
downloadFile := filepath.Join(featureFolder, "feature.tgz")
err = downloadFeatureFromURL(id, downloadFile, httpHeaders)
if err != nil {
log.Errorf("failed to download feature tarball: error=%v, url=%s", err, id)
log.Debugf("failed to download feature tarball: error=%v, url=%s", err, id)
return "", err
}

storeIntegrityHash(featureFolder, downloadFile, id)

if err := extractTarball(downloadFile, featureExtractedFolder); err != nil {
log.Errorf("failed to extract tarball: error=%v, featureId=%s", err, id)
log.Debugf("failed to extract tarball: error=%v, featureId=%s", err, id)
return "", err
}

Expand All @@ -415,7 +413,6 @@ func downloadFeatureFromURL(
// #nosec G301 -- TODO Consider using a more secure permission setting and ownership if needed.
err := os.MkdirAll(filepath.Dir(destFile), 0o755)
if err != nil {
log.Errorf("failed to create feature folder: error=%v, dir=%s", err, filepath.Dir(destFile))
return fmt.Errorf("create feature folder: %w", err)
}

Expand All @@ -430,7 +427,6 @@ func downloadFeatureFromURL(
log.Debugf("download feature: url=%s", url)
if err := tryDownload(url, destFile, httpHeaders); err != nil {
if attempt == 2 {
log.Errorf("all download attempts failed: error=%v, url=%s", err, url)
return err
}
log.Debugf("download attempt failed: error=%v, attempt=%v", err, attempt)
Expand Down
Loading