fix(desktop): scope Node.js template e2e selector to active tab panel#555
Merged
Conversation
The wizard Source step's "Node.js" template button collided with the Image catalog's "Node.js 20" card (both present in the DOM), causing an intermittent Playwright strict-mode violation on the integration e2e. Scope the locator to the active tabpanel, matching the existing Python-template flow and workspaces.e2e.ts.
✅ Deploy Preview for images-devsy-sh canceled.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn the Node.js workspace creation e2e test, the Step 2 template selection now scopes the "Node.js" button click to the dialog's active Workspace Lifecycle E2E
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for devsydev canceled.
|
skevetter
marked this pull request as ready for review
June 29, 2026 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
integration.e2e.ts"should create Node.js workspace" test intermittently failed on Windows with a Playwright strict-mode violation:Both tab panels stay in the DOM, so the unscoped
hasText: "Node.js"selector matched both whenever the async image catalog finished loading before the click — a race, which is why the same commit both passed and failed.Fix: scope the locator to the active
tabpanel, matching the pattern already used by the sibling Python-template flow in the same file and byworkspaces.e2e.ts.Pre-existing flake, unrelated to the change that surfaced it.
Summary by CodeRabbit