Skip to content

fix(desktop): scope Node.js template e2e selector to active tab panel #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Jun 29, 2026
Merged

fix(desktop): scope Node.js template e2e selector to active tab panel #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions desktop/e2e/integration.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,13 @@ test.describe
await dialog.locator("button", { hasText: "docker" }).first().click()
await dialog.getByRole("button", { name: /^continue$/i }).click()

// Step 2 — Source: click Node.js template
await dialog.locator("button", { hasText: "Node.js" }).click()
// Step 2 — Source: click Node.js template. Scope to the active tab panel
// (Git) so the template button doesn't collide with the Image catalog's
// "Node.js 20" card, which is also present in the DOM.
await dialog
.getByRole("tabpanel")
.locator("button", { hasText: "Node.js" })
.click()
const sourceInput = dialog.locator('input[placeholder*="github"]')
await expect(sourceInput).toHaveValue(
"https://github.com/microsoft/vscode-remote-try-node",
Expand Down
Loading