feat(desktop): add confirmation dialogs for workspace rebuild and reset#627
Merged
Conversation
Rebuild and Reset fired immediately with no explanation of their effects. Reset is destructive (removes the cloned source along with the container) yet had no warning, unlike the safer Delete and Rename actions which already confirm. Add ConfirmDialog prompts for both, matching the existing convention, with descriptions grounded in the CLI flag semantics (up --recreate vs up --reset).
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
skevetter
marked this pull request as ready for review
July 8, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Rebuild and Reset buttons on the workspace details page fired immediately with no explanation of their effects. Reset is destructive — the CLI
up --resetflag removes the cloned source code along with the container — yet it had no warning, unlike the safer Delete and Rename actions which already confirm.This adds
ConfirmDialogprompts for both actions, matching the existing convention, so users understand what each does before proceeding:up --recreate): non-destructive-styled dialog explaining it recreates the container from the devcontainer config, keeps source code, and loses only manual in-container changes.up --reset): destructive-styled dialog making clear the container and cloned source code are removed, so uncommitted/unpushed changes are permanently lost.Help text is grounded in the actual CLI flag semantics in
cmd/workspace/up/up_flags.go.