Skip to content

feat(desktop): add confirmation dialogs for workspace rebuild and reset #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Jul 8, 2026
Merged

feat(desktop): add confirmation dialogs for workspace rebuild and reset #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions desktop/src/renderer/src/pages/WorkspaceDetailPage.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ let confirmDeleteOpen = $state(false)
let deleting = $state(false)
let confirmRenameOpen = $state(false)
let pendingRenameTarget = $state("")
let confirmRebuildOpen = $state(false)
let confirmResetOpen = $state(false)

let hasContainer = $derived.by(() => {
const status = workspace?.status?.toLowerCase()
Expand Down Expand Up @@ -379,6 +381,7 @@ async function handleStop() {
}

async function handleRebuild() {
confirmRebuildOpen = false
startStreamingOp("Rebuild")
try {
commandId = await workspaceRebuild(id, isDebug())
Expand All @@ -389,6 +392,7 @@ async function handleRebuild() {
}

async function handleReset() {
confirmResetOpen = false
startStreamingOp("Reset")
try {
commandId = await workspaceReset(id, isDebug())
Expand Down Expand Up @@ -526,11 +530,11 @@ async function handleRenameConfirmed() {
{/snippet}
</DropdownMenu.Trigger>
<DropdownMenu.Content align="end">
<DropdownMenu.Item onclick={handleRebuild} disabled={operationRunning}>
<DropdownMenu.Item onclick={() => (confirmRebuildOpen = true)} disabled={operationRunning}>
<RotateCcw class="mr-2 h-4 w-4" />
Rebuild
</DropdownMenu.Item>
<DropdownMenu.Item onclick={handleReset} disabled={operationRunning}>
<DropdownMenu.Item onclick={() => (confirmResetOpen = true)} disabled={operationRunning}>
<RefreshCw class="mr-2 h-4 w-4" />
Reset
</DropdownMenu.Item>
Expand Down Expand Up @@ -833,6 +837,23 @@ async function handleRenameConfirmed() {
{/if}
</div>

<ConfirmDialog
bind:open={confirmRebuildOpen}
title="Rebuild workspace"
description="This recreates the container for '{id}' from its devcontainer config. Your source code is kept, but anything installed inside the container outside the devcontainer config (e.g. manual 'apt install', files outside bind mounts) will be lost. Use this to pick up devcontainer changes or recover from a broken container."
confirmLabel="Rebuild"
variant="default"
onconfirm={handleRebuild}
/>

<ConfirmDialog
bind:open={confirmResetOpen}
title="Reset workspace"
description="This removes the container for '{id}' along with its cloned source code, then recreates everything from scratch. Any uncommitted changes and files not pushed to your repository will be permanently lost. This action cannot be undone."
confirmLabel="Reset"
onconfirm={handleReset}
/>

<ConfirmDialog
bind:open={confirmDeleteOpen}
title="Delete workspace"
Expand Down
Loading