Added whitespace stripping to remove unwanted empty spaces/newlines that can cause changes to userdata - #2056
Closed
wcarlsen wants to merge 3 commits into
Closed
Added whitespace stripping to remove unwanted empty spaces/newlines that can cause changes to userdata#2056wcarlsen wants to merge 3 commits into
wcarlsen wants to merge 3 commits into
Conversation
…hat can cause changes to userdata Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Mik-Nord
approved these changes
Oct 22, 2025
Contributor
Author
|
This is blocked and eventhough purely cosmetic it will cause a node roll over. |
wcarlsen
added a commit
that referenced
this pull request
Jun 11, 2026
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Contributor
Author
|
This PR has been swallowed by this instead #2380 |
4 tasks
wcarlsen
added a commit
that referenced
this pull request
Jun 29, 2026
…bled by default (#2380) * Remove eks_addon_vpccni_prefix_delegation_enabled var and make it enabled by default Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com> * Add test to verify prefix delegation is enabled Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com> * Swallow changes from #2056 since this is noderoller anyways Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com> --------- Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
When doing logic within templates it is important to use whitespace stripping in most cases, especially for userdata, specially for if-else statements.
Issue ticket number and link
Checklist before requesting a review
test/integrationfolder to apply my changes in QA. Read the guide on adding environment variables in QAIs it a new release?
release:(major|minor|patch), following semantic versioning in this guide ornoreleaseif there is no changes to the Terraform code