Remove eks_addon_vpccni_prefix_delegation_enabled var and make it enabled by default - #2380
Merged
wcarlsen merged 7 commits intoJun 29, 2026
Merged
Conversation
…bled by default Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
… github.com:dfds/infrastructure-modules into remove/eks/addon/vpc-cni/prefix-delegation-variable
rifisdfds
approved these changes
Jun 15, 2026
Mik-Nord
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
VPC prefix delegation is enabled in all our shared clusters see https://github.com/dfds/eks-pipeline/blob/91b62ba71cef0136f8a434f38eb3a7115743aa2c/cluster.hcl#L9, but apparently still disabled by default here. So we remove the variable and enable the feature by default.
As a side effect max_pods default of 110 will always be set unless explicitly overwritten. This is in my mind a sane default and also what the Kubernetes team recommends. Plus this behavior was already present in our shared clusters.
Since this will cause a noderollover we swallow this #2056 in this one as well.
Issue ticket number and link
Checklist before requesting a review
test/integrationfolder to apply my changes in QA. Read the guide on adding environment variables in QAIs it a new release?
release:(major|minor|patch), following semantic versioning in this guide ornoreleaseif there is no changes to the Terraform code