Skip to content

Remove eks_addon_vpccni_prefix_delegation_enabled var and make it enabled by default - #2380

Merged
wcarlsen merged 7 commits into
masterfrom
remove/eks/addon/vpc-cni/prefix-delegation-variable
Jun 29, 2026
Merged

Remove eks_addon_vpccni_prefix_delegation_enabled var and make it enabled by default#2380
wcarlsen merged 7 commits into
masterfrom
remove/eks/addon/vpc-cni/prefix-delegation-variable

Conversation

@wcarlsen

@wcarlsen wcarlsen commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

VPC prefix delegation is enabled in all our shared clusters see https://github.com/dfds/eks-pipeline/blob/91b62ba71cef0136f8a434f38eb3a7115743aa2c/cluster.hcl#L9, but apparently still disabled by default here. So we remove the variable and enable the feature by default.

As a side effect max_pods default of 110 will always be set unless explicitly overwritten. This is in my mind a sane default and also what the Kubernetes team recommends. Plus this behavior was already present in our shared clusters.

Since this will cause a noderollover we swallow this #2056 in this one as well.

Issue ticket number and link

Checklist before requesting a review

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

wcarlsen added 2 commits June 11, 2026 10:07
…bled by default

Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
@wcarlsen
wcarlsen requested a review from a team as a code owner June 11, 2026 08:17
@wcarlsen wcarlsen added the release:major Triggers a major release label Jun 11, 2026
@DFDS-Snyk

DFDS-Snyk commented Jun 11, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

wcarlsen added 3 commits June 11, 2026 10:58
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
… github.com:dfds/infrastructure-modules into remove/eks/addon/vpc-cni/prefix-delegation-variable
@wcarlsen
wcarlsen merged commit 27db96a into master Jun 29, 2026
13 checks passed
@wcarlsen
wcarlsen deleted the remove/eks/addon/vpc-cni/prefix-delegation-variable branch June 29, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:major Triggers a major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants