fix: issue #11947 - rfc-add-interpretability-api-as-xgboost-interpret-module-fun#12119
Closed
t7r0n wants to merge 11 commits intodmlc:masterfrom
Closed
fix: issue #11947 - rfc-add-interpretability-api-as-xgboost-interpret-module-fun#12119t7r0n wants to merge 11 commits intodmlc:masterfrom
t7r0n wants to merge 11 commits intodmlc:masterfrom
Conversation
Contributor
Author
|
Pushed a cleanup commit to fix CI noise from accidentally committed workspace files. Summary:
Local validation:
I am monitoring the new CI run on this head SHA and will follow up if any remaining failure is code-related. |
Contributor
Author
|
Follow-up fix pushed for the remaining Debian R failure. Root cause from CI log:
Change:
Local validation:
Monitoring the new CI run on this head SHA. |
Contributor
Author
|
Pushed an empty commit to retrigger CI only. Reason:
No source files were modified in this commit; this is CI retrigger only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deliver the minimal Python interpretability surface for issue #11947 and complete retry pass
repair-2by fixing the recorded lint instability.What changed
python-package/xgboost/interpret.py:shap_values(...)shap_interactions(...)interpretinpython-package/xgboost/__init__.pyand kept it in__all__.tests/python/test_shap.py(TestInterpret).Repair-2 remediation (required failure only)
.bot/validation_failures.md.python-package/xgboost/__init__.pyuses separate import lines:from . import collectivefrom . import interprettests/python/test_shap.pyhas no extra blank line between:import scipy.specialimport xgboost as xgbValidation
pre-commit run --files python-package/xgboost/__init__.py tests/python/test_shap.py --show-diff-on-failurepython -m py_compile python-package/xgboost/interpret.py tests/python/test_shap.py python-package/xgboost/__init__.pyPYTHONPATH=python-package python -m pytest tests/python/test_shap.py -k "TestInterpret" -qModuleNotFoundError: No module named 'numpy'Scope discipline
Branch Policy Compatibility
masterforkt7r0n/xgboost