Skip to content

commands: use buildx env for experimental opt-in#1267

Merged
jedevc merged 1 commit into
docker:masterfrom
tonistiigi:buildx-env
Aug 16, 2022
Merged

commands: use buildx env for experimental opt-in#1267
jedevc merged 1 commit into
docker:masterfrom
tonistiigi:buildx-env

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

I messed this up when doing the final review edits for #1100

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi added this to the v0.9.0 milestone Aug 12, 2022
@jedevc jedevc merged commit fb5e139 into docker:master Aug 16, 2022
@crazy-max
Copy link
Copy Markdown
Member

Missed

if v, ok := os.LookupEnv("BUILDKIT_EXPERIMENTAL"); ok {

Also don't think we need to say BUILDX_EXPERIMENTAL=1 is required. for this flag as it's hidden behind the isExperimental() cond anyway.

@jedevc
Copy link
Copy Markdown
Collaborator

jedevc commented Aug 16, 2022

Woops, we should definitely be consistent with keeping BUILDX_EXPERIMENTAL=1 is required. between --invoke and --print. I think some sort of (experimental) note after both would be nice though - just to indicate that it has been activated with the isExperimental condition.

@crazy-max
Copy link
Copy Markdown
Member

@jedevc Sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants