Skip to content

Consistent experimental help#1274

Merged
jedevc merged 2 commits into
docker:masterfrom
jedevc:consistent-experimental-help
Aug 18, 2022
Merged

Consistent experimental help#1274
jedevc merged 2 commits into
docker:masterfrom
jedevc:consistent-experimental-help

Conversation

@jedevc
Copy link
Copy Markdown
Collaborator

@jedevc jedevc commented Aug 16, 2022

Follow-up to #1267

This patch ensures that we have consistent help messages between the two experimental options, and additionally adds the experimental options to the command reference along with information on how to enable them.

Append an [experimental] tag to the end of each experimental command to
highlight that these are experimental options. Square brackets are used
instead of parentheses as parentheses are already in use to highlight
examples and defaults.

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc requested review from crazy-max and tonistiigi August 16, 2022 10:22
Comment thread hack/dockerfiles/docs.Dockerfile Outdated
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc force-pushed the consistent-experimental-help branch from cc0241a to 297526c Compare August 16, 2022 11:41
Comment thread commands/build.go
Copy link
Copy Markdown
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, PTAL @tonistiigi

@jedevc jedevc merged commit 441853f into docker:master Aug 18, 2022
@jedevc jedevc deleted the consistent-experimental-help branch August 18, 2022 08:37
@crazy-max crazy-max added this to the v0.9.1 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants