tests: handle multiple docker versions#2307
Merged
Merged
Conversation
ba4ec65 to
5a62074
Compare
5a62074 to
cf4bc57
Compare
b36edca to
b0f8fcc
Compare
Member
Author
|
@tonistiigi As discussed we could also handle builders through |
This was referenced Mar 13, 2024
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
b0f8fcc to
a69d857
Compare
crazy-max
commented
Nov 20, 2024
|
|
||
| # for testing | ||
| ARG DOCKER_VERSION=27.4.0-rc.2 | ||
| ARG DOCKER_VERSION_ALT_26=26.1.3 |
Member
Author
There was a problem hiding this comment.
26.1.3 is the current version shipped on GitHub runners. I think it makes sense to test this alt version.
tonistiigi
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs testutil: add binary and extraEnv opt for dockerd worker moby/buildkit#4736