dockerfile: use moby-bin and cli-bin images for docker binaries#2321
Merged
Conversation
thaJeztah
reviewed
Mar 7, 2024
Comment on lines
+23
to
+24
| FROM moby/moby-bin:$DOCKER_VERSION AS docker-engine | ||
| FROM dockereng/cli-bin:$DOCKER_VERSION AS docker-cli |
Member
There was a problem hiding this comment.
Do you think there's a need to call out that these are automated builds, not "official releases" (for the occasional reader)?
(We should also really fix those repositories to have a readme to outline their purpose / give the right expectations 😞 - let me see if someone can work on that)
Member
Author
There was a problem hiding this comment.
Added "for testing" comment on args if that sgty.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
docker-use-bin-images
branch
from
37adb5a to
70a28fe
Compare
thaJeztah
approved these changes
Mar 7, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, yes, that comment should do for now. I created an internal ticket to look at adding README's to those repositories.
thaJeztah
reviewed
Mar 7, 2024
Comment on lines
7
to
10
| ARG DOCKER_VERSION=25.0.2 | ||
| ARG GOTESTSUM_VERSION=v1.9.0 | ||
| ARG REGISTRY_VERSION=2.8.0 | ||
| ARG BUILDKIT_VERSION=v0.12.5 |
Member
There was a problem hiding this comment.
Looks like we have some versions to update here (probably fine to be done separate)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
picked from #2307
we can now use
moby/moby-binanddockereng/cli-binimages for testing docker in our integration tests.