Overhaul custom authz policy provider article - #37379
Open
guardrex wants to merge 13 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request overhauls the existing authorization policy provider documentation by renaming/replacing the old iauthorizationpolicyprovider.md article with a new, expanded article focused on Blazor Web Apps and Minimal APIs, and updates navigation and redirections accordingly.
Changes:
- Replaces the old
security/authorization/iauthorizationpolicyproviderarticle withsecurity/authorization/custom-authorization-policy-providersand updates TOC + cross-references. - Adds a redirection from the deleted article path to the new article path.
- Updates the shared
git-downloadinclude content used by the new article.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| aspnetcore/toc.yml | Updates TOC entry to point to the new article UID. |
| aspnetcore/security/authorization/policies.md | Updates the cross-reference to the renamed policy provider article. |
| aspnetcore/security/authorization/iauthorizationpolicyprovider.md | Deletes the old article in favor of the new replacement article. |
| aspnetcore/security/authorization/custom-authorization-policy-providers.md | Adds the new, expanded replacement article content. |
| aspnetcore/includes/git-download.md | Updates the sparse-checkout tip content used by the new article. |
| .openpublishing.redirection.json | Adds a redirect from the deleted article path to the new article path. |
Comments suppressed due to low confidence (1)
aspnetcore/security/authorization/custom-authorization-policy-providers.md:152
- The
:::codedirective already inserts the referenced sample file, but the article also includes a second, inline copy of the same code plus a "DOC REVIEWER NOTE" that says it will be removed. This will duplicate content in the rendered article and should be cleaned up before merge (keep either:::codeor the inline copy, but not both).
:::code language="csharp" source="~/../AspNetCore.Docs.Samples/security/authorization/BlazorWebAppAuthorization/Policies/Attributes/MinimumAgeAuthorizeAttribute.cs":::
<!-- DOC REVIEWER NOTE: The preceding cross-link inserts the following code.
The following code will be removed prior to merging
the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37370
Fixes #19611
Fixes #34469
Addresses #35801
Notes
custom-authorization-policy-providers.md, and I like to match the UID for such changes.IAuthorizationPolicyProviderin a single reference section and not have it sprinkled down into other sections of the article later, which is more like what I would expect a tutorial to do. I also think that we need to bring more of the (hidden) framework code remarks into the article.BlazorWebAppAuthorizationsample app is shown inline for easy reviewing of this PR. I'll pull that sample code out of the article before merging this PR.🦖 NOTE TO SELF 🦖 - Remove the inline code before merging this PR!
API cross-links ...