[tests] support for running tests on VSTS - #1418
Merged
Merged
Conversation
Member
Author
|
Waiting on dotnet/java-interop#274 to finish this up. |
jonathanpeppers
force-pushed
the
windows-nunit
branch
from
March 20, 2018 16:34
73c7610 to
be41709
Compare
jonathanpeppers
changed the title
jonpryor
pushed a commit
that referenced
this pull request
Mar 21, 2018
jonathanpeppers
force-pushed
the
windows-nunit
branch
from
March 21, 2018 13:48
be41709 to
34b93e6
Compare
To get our desired behavior on VSTS, we have to: - Make sure our call to NUnit returns a failing exit code - Set the "Continue on Error" option in VSTS - Add a step at the end of our build definition in VSTS to fail the build if any issues ocurred To make this work, we have to change our `<Exec />` task usage to `ContinueOnError="ErrorAndContinue"`. Example builds with a failing test can be found here: - https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1502302&tab=ms.vss-test-web.test-result-details - https://jenkins.mono-project.com/job/xamarin-android-pr-builder/2739/
jonathanpeppers
force-pushed
the
windows-nunit
branch
from
March 21, 2018 14:49
34b93e6 to
6bbaf39
Compare
Member
Author
|
Changes needed on VSTS have been published here. Apparently, my draft build link on VSTS no longer works after publishing 😕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get our desired behavior on VSTS, we have to:
build if any issues ocurred
To make this work, we have to change our
<Exec />task usage toContinueOnError="ErrorAndContinue".Example builds with a failing test can be found here: