Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

[build] fix for unit tests to run on VSTS - #274

Merged
jonpryor merged 1 commit into
dotnet:masterfrom
jonathanpeppers:vsts-nunit
Mar 20, 2018
Merged

[build] fix for unit tests to run on VSTS#274
jonpryor merged 1 commit into
dotnet:masterfrom
jonathanpeppers:vsts-nunit

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

To get our desired behavior on VSTS, we have to:

  • Make sure our call to NUnit returns a failing exit code
  • Set the "Continue on Error" option in VSTS
  • Add a step at the end of our build definition in VSTS to fail the
    build if any issues ocurred

To make this work, we have to change our <Exec /> task usage to
ContinueOnError="ErrorAndContinue".

I tested the VSTS behavior upstream in xamarin-android, see a build here:
https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1478269

Other changes:

  • Added Resource.designer.cs to .gitignore to match xamarin-android

To get our desired behavior on VSTS, we have to:
- Make sure our call to NUnit returns a failing exit code
- Set the "Continue on Error" option in VSTS
- Add a step at the end of our build definition in VSTS to fail the
build if any issues ocurred

To make this work, we have to change our `<Exec />` task usage to
`ContinueOnError="ErrorAndContinue"`.

I tested the VSTS behavior upstream in xamarin-android, see a build here:
https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1478269

Other changes:
- Added `Resource.designer.cs` to .gitignore to match xamarin-android
@jonpryor
jonpryor merged commit 6807817 into dotnet:master Mar 20, 2018
@jonathanpeppers
jonathanpeppers deleted the vsts-nunit branch March 20, 2018 16:33
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants