Add RuntimeConfiguration flags to have more flexibility on SkipOnCoreClrAttribute - #4764
Conversation
| { | ||
| Any = ~0, | ||
| Checked = 1, | ||
| Release = 1 << 1, |
There was a problem hiding this comment.
I don't expect us to be needing to disable on Debug mode, but should we add it for consistency and completeness?
There was a problem hiding this comment.
Yeah I would add it for the sake of completeness. I'm sure somebody will ask for it sooner or later.
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
| // Licensed to the .NET Foundation under one or more agreements. |
There was a problem hiding this comment.
Double copyright to be super safe? :)
|
Merging now. If someone has any follow up feedback I can address later. |
| public enum RuntimeConfiguration | ||
| { | ||
| Any = ~0, | ||
| Checked = 1, |
There was a problem hiding this comment.
If Checked is too slow for something, Debug is going to be too slow as well. Are people supposed to always use Checked together with Debug?
There was a problem hiding this comment.
Actually, I am getting tired of the Debug vs. Checked conundrum. Wrote a proposal here: dotnet/runtime#31852
There was a problem hiding this comment.
Ha, I'm glad I inspired you on this.
I wouldn't expect people to have to use Debug at the moment in these attributes as we don't run those tests on CI, but if needed let me know and I can update to skip on both when either flag is present.
3 participants
This gives us the flexibility of disabling for a stress mode in a specific configuration or for disabling in any stress mode in any configuration, or to disable for just one configuration, etc. Before these where exclusive, it was either one or the other, now we can disable with more granularity.
Also added license files.