Update SkipOnCoreClrAttributes to RuntimeConfiguration argument - #31847
Merged
Conversation
safern
added
the
NO-MERGE
Member
Author
|
Apparently some tests are not being skipped. Will investigate. |
Member
Author
|
I put up the fix here: dotnet/arcade#4776 |
safern
removed
the
NO-MERGE
ViktorHofer
approved these changes
Feb 6, 2020
ViktorHofer
left a comment
ViktorHofer
left a comment
Member
There was a problem hiding this comment.
pls fix the merge conflict in eng/Version.Details.xml. Otherwise looks great.
Member
Author
Done... lame that I just forgot to do ctrl + save as VSCode doesn't save the file when you choose which changes to preserve 🤦♂ |
Member
Author
|
Failure is: #2176 |
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reacts to changes in: dotnet/arcade#4764
cc: @ViktorHofer @stephentoub