Enable build of ARM64 installers in ASP.NET Core by hoyosjs · Pull Request #25579 · dotnet/aspnetcore

hoyosjs · 2020-09-03T19:35:05Z

Enable ARM64 installers build.

Changes WiX toolset used to 3.14 to support ARM64
Generates targeting pack from the x86/x64 leg, as it gets produced using a zip that gets generated there.
The ARM leg now produces all the necessary msi's, exe, and wixlib needed for the installer to generate a bundle.

hoyosjs · 2020-09-03T19:41:38Z

I added this feed for testing. The main issue was that WiX doesn't have a package for the toolset that supports ARM64. Other repositories don't use wixproj, so we didn't need it before this. I don't know what feed this should go to, or if this is even a good idea.

Using general-testing is not a good idea because pretty much anything could be pushed there. Suggest working w/ core-eng to get the new WiX into dotnet-eng

Yeah, this was to verify this won't break in CI. I'm asking for some guidance from the engineering team here.

@dougbu I got the green light to move this as is to dotnet-eng. I've reverted all changes to NuGet.config

hoyosjs · 2020-09-03T22:28:21Z

Official test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=800872&view=results

Further validation:

Confirmed files are R2R, signed files.
Now checking registry keys and signatures of the bundles.

cc: @joeloff, @tommcdon, @dougbu

Pilchie · 2020-09-03T22:50:40Z

Do we want to target this to release/5.0-rc2?

hoyosjs · 2020-09-03T22:54:28Z

@Pilchie, yes. I will port once this gets reviewed and goes in.

joeloff · 2020-09-03T22:56:24Z

@Pilchie if we did, we might be able to unblock the SDK and get that part completed for RC2 as well, but it would be tight. I'll have a chat with other SDK folks. @marcpopMSFT as an FYI

tommcdon · 2020-09-03T22:59:58Z

FYI @richlander

dougbu · 2020-09-04T21:52:14Z

Using general-testing is not a good idea because pretty much anything could be pushed there. Suggest working w/ core-eng to get the new WiX into dotnet-eng

dougbu · 2020-09-08T16:04:28Z

I can't approve this until the general-testing feed is removed. @hoyosjs you've addressed my other comments well. (nit: "only" isn't spelled "inly" even in comments.)

Also suggest @joeloff or someone else w/ more Wix knowledge have a look at these changes. They follow the existing patterns but I may be missing something.

dougbu

I'm fine with this but would really appreciate additional eyes on it @joeloff @dotnet/aspnet-build or anyone w/ more WiX experience than me, please chime in.

joeloff · 2020-09-09T18:59:31Z

Looks good. I'm guessing that the hosting bundle will remain x86/x64 only for the time being. Unlike the other installers, the hosting bundle prefers to install all architectures by default and I think there will be a clash since for x64, there aren't new properties defined yet (at least none that I can see in Windows).

My big concern is the wixlib because we rely on that to share the package chaining across the shared framework, hosting and SDK installer bundles.

hoyosjs · 2020-09-09T19:06:23Z

@joeloff any verification I can do to verify? I have official runs so I have signed installers and can test anything that's needed. However, this is becoming time sensitive.

joeloff · 2020-09-09T19:16:10Z

@hoyosjs if the have the signed MSI, you can try them out on a VM. You can also double check the Product/Upgrade code for the x64/arm64 MSIs just to be sure they are different (you can use ORCA for that). The build seeds the GUIDs using the Platform property, so they should be different.

hoyosjs · 2020-09-09T22:02:27Z

@joeloff I've tested this:

My big concern is the wixlib because we rely on that to share the package chaining across the shared framework, hosting and SDK installer bundles.

Do you have a particular concern I can check against?

hoyosjs · 2020-09-09T22:09:07Z

Issues I keep hitting are #25623 and a gradle issue solved by #25707. Closing and reopening to create a rebase.

hoyosjs · 2020-09-10T03:29:28Z

@dougbu I've tried rebasing but I keep getting red. Looking around I see you had a comment describing all the issues I've seen. However they seem to have gotten fixes upstream, but they keep failing. Any advice?

Add Public API baselines for Security #25651 hit another flaky Razor SDK test (BundlesScopedCssFiles_UpdatesBundleWhenContentsChange)

this test failure impacted most, if not all, of these PRs

Add public API baselines for Servers #25652 hit the PDB duplication build problem in both aspnetcore-ci and aspnetcore-quarantined-pr

Add public API baselines to SignalR #25653 hit the gradlew build problem @halter73

Add public API baselines for SiteExtensions, Testing, WebEncoders #25654 hit the PDB duplication build problem but only in the aspnetcore-quarantined-pr pipeline

#25293 (comment)

dougbu · 2020-09-10T03:43:14Z

@hoyosjs the problem here is you're targeting the master branch and all the fixes mentioned have been checked into release/5.0-rc2. Need to either wait for #25650 to merge or target release/5.0-rc2 instead. Recommend doing the second because time for RC2 is getting short.

Changes WiX toolset used to 3.14 to support ARM64 Generates targeting pack from the x86/x64 leg, as it gets produced using a zip that gets generated there. The ARM64 leg now produces all the necessary msi's, exe, and wixlib needed for the installer to generate a bundle.

hoyosjs · 2020-09-10T06:33:24Z

@dougbu I didn't know there was an automated FI from RC2 to master. I've retargeted this to RC2.

hoyosjs · 2020-09-10T06:34:12Z

Feel free to merge once it's green

@Pilchie can this please be considered for RC2 for the ARM64 installer?

ghost · 2020-09-10T17:14:34Z

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

dougbu · 2020-09-10T17:20:14Z

All checks 🟢 Waiting on your word @Pilchie…

Pilchie · 2020-09-10T17:49:29Z

Just wanted to double check with Tactics - we're good to merge this now.

Pilchie · 2020-09-10T17:49:49Z

Approved for .NET 5 RC2.

dougbu · 2020-09-10T18:00:15Z

Thanks very much @hoyosjs❕

Changes WiX toolset used to 3.14 to support ARM64 Generates targeting pack from the x86/x64 leg, as it gets produced using a zip that gets generated there. The ARM64 leg now produces all the necessary msi's, exe, and wixlib needed for the installer to generate a bundle.

* Enable ARM64 installers build. (#25579) Changes WiX toolset used to 3.14 to support ARM64 Generates targeting pack from the x86/x64 leg, as it gets produced using a zip that gets generated there. The ARM64 leg now produces all the necessary msi's, exe, and wixlib needed for the installer to generate a bundle. * Build tageting pack installers * Set TP version to 3.1.10

hoyosjs commented Sep 3, 2020

View reviewed changes

Comment thread eng/Build.props Outdated

hoyosjs marked this pull request as ready for review September 3, 2020 22:27

Pilchie requested a review from JunTaoLuo September 3, 2020 22:49

Pilchie assigned JunTaoLuo Sep 3, 2020

Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 3, 2020

dougbu suggested changes Sep 4, 2020

View reviewed changes

dougbu requested a review from joeloff September 8, 2020 16:04

dougbu approved these changes Sep 8, 2020

View reviewed changes

joeloff approved these changes Sep 9, 2020

View reviewed changes

hoyosjs closed this Sep 9, 2020

hoyosjs reopened this Sep 9, 2020

hoyosjs force-pushed the juhoyosa/arm64-installers branch from 5b999ec to 838459c Compare September 10, 2020 02:33

hoyosjs changed the base branch from master to release/5.0-rc2 September 10, 2020 06:20

hoyosjs requested review from BrennanConroy, halter73 and jkotalik as code owners September 10, 2020 06:20

hoyosjs requested review from a team, SteveSandersonMS and Tratcher as code owners September 10, 2020 06:20

hoyosjs force-pushed the juhoyosa/arm64-installers branch from 838459c to 8c5cdc3 Compare September 10, 2020 06:30

hoyosjs mentioned this pull request Sep 10, 2020

Finalize ARM64 support (Installers, publishing-rid, revert winforms support) dotnet/installer#8470

Merged

Pilchie added the Servicing-consider Shiproom approval is required for the issue label Sep 10, 2020

Pilchie added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 10, 2020

dougbu merged commit dda1d33 into dotnet:release/5.0-rc2 Sep 10, 2020

tommcdon mentioned this pull request Sep 10, 2020

Support Windows ARM64 dotnet/runtime#36699

Closed

10 tasks

Uh oh!

Conversation

hoyosjs commented Sep 3, 2020

Uh oh!

hoyosjs Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

dougbu Sep 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoyosjs Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoyosjs Sep 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hoyosjs commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pilchie commented Sep 3, 2020

Uh oh!

hoyosjs commented Sep 3, 2020

Uh oh!

joeloff commented Sep 3, 2020

Uh oh!

tommcdon commented Sep 3, 2020

Uh oh!

dougbu Sep 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dougbu commented Sep 8, 2020

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

joeloff commented Sep 9, 2020

Uh oh!

hoyosjs commented Sep 9, 2020

Uh oh!

joeloff commented Sep 9, 2020

Uh oh!

hoyosjs commented Sep 9, 2020

Uh oh!

hoyosjs commented Sep 9, 2020

Uh oh!

hoyosjs commented Sep 10, 2020

Uh oh!

dougbu commented Sep 10, 2020

Uh oh!

hoyosjs commented Sep 10, 2020

Uh oh!

hoyosjs commented Sep 10, 2020

Uh oh!

ghost commented Sep 10, 2020

Uh oh!

dougbu commented Sep 10, 2020

Uh oh!

Pilchie commented Sep 10, 2020

Uh oh!

Pilchie commented Sep 10, 2020

Uh oh!

dougbu commented Sep 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dougbu Sep 4, 2020 •

edited

Loading

hoyosjs Sep 8, 2020 •

edited

Loading

hoyosjs commented Sep 3, 2020 •

edited

Loading

dougbu Sep 4, 2020 •

edited

Loading