Add public API baselines to SignalR - #25653
Conversation
|
Part of #24347 |
There was a problem hiding this comment.
nit: Should we craft a better Justification for the many T1 parameter, CancellationToken token = default, T2 parameter, CancellationToken token = default, … cases❔ If we were adding HubConnectionContext tomorrow, I bet we'd use the same set of overloads. Perhaps,
| [SuppressMessage("ApiDesign", "RS0026:Do not add multiple overloads with optional parameters", Justification = "Required to maintain compatibility")] | |
| [SuppressMessage("ApiDesign", "RS0026:Do not add multiple overloads with optional parameters", Justification = "May need a CancellationToken with either of these message types.")] |
Of course, if you do that here, we'd need to look at the rest of our open PRs and I'm not sure it's worthwhile.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hello @Pilchie! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, it looks like |
9093514 to
ec21fba
Compare
No description provided.