Skip to content

Remove redundant site extension fix - #27855

Merged
wtgodbe merged 1 commit into
release/5.0from
johluo/cleanup
Dec 9, 2020
Merged

Remove redundant site extension fix#27855
wtgodbe merged 1 commit into
release/5.0from
johluo/cleanup

Conversation

@JunTaoLuo

Copy link
Copy Markdown
Contributor

Missed the revert of an earlier fix in #27841.

@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework auto-merge tell-mode Indicates a PR which is being merged during tell-mode labels Nov 15, 2020
@JunTaoLuo
JunTaoLuo requested a review from dougbu November 15, 2020 04:57
@ghost ghost added the area-hosting label Nov 15, 2020
@ghost

ghost commented Nov 15, 2020

Copy link
Copy Markdown

Hello @JunTaoLuo!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@JunTaoLuo

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@Pilchie

Pilchie commented Nov 23, 2020

Copy link
Copy Markdown
Member

@BrennanConroy @jkotalik - do you know if we need this for 5.0.1?

@BrennanConroy

Copy link
Copy Markdown
Member

I assume this was just adding extra files to the package that should have no effect on users.

Since it was accidentally added in 5.0.1 I think removing it in 5.0.1 is fine.

@jkotalik

Copy link
Copy Markdown
Contributor

I think we should try getting this into 5.0.1

@jkotalik

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@dougbu

dougbu commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

This is good cleanup but the timing isn't critical. @JunTaoLuo is removing a confusing mention of files that no longer exist and never shipped in any package.

@dougbu

dougbu commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

BTW, the not-in-any-package part is because @(_TemplateFiles) become part of a generated project, not directly part of a package.

@JunTaoLuo

Copy link
Copy Markdown
Contributor Author

FYI, I'll withhold this cleanup PR for the next servicing release since it's not urgent.

@wtgodbe
wtgodbe merged commit 8a3c865 into release/5.0 Dec 9, 2020
@wtgodbe
wtgodbe deleted the johluo/cleanup branch December 9, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants