Skip to content

Bump Selenium dependency versions - #27947

Merged
BrennanConroy merged 4 commits into
masterfrom
safia/selenium-bump
Nov 19, 2020
Merged

Bump Selenium dependency versions#27947
BrennanConroy merged 4 commits into
masterfrom
safia/selenium-bump

Conversation

@captainsafia

@captainsafia captainsafia commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

These changes are made to resolve some instability we've been seeing with Selenium tests in the CI.

  • Bump to the latest version of Seleniums 4.x package versions
  • Bump to a supported version of the Chrome drivers
  • Quarantine a Blazor tests that performs unreliably in newer versions of Chrome

@captainsafia
captainsafia requested a review from dougbu as a code owner November 18, 2020 16:54
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 18, 2020

@dougbu dougbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised 4.0.0 isn't out but change looks good

@dougbu

dougbu commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

@captainsafia do you expect this will fix both the on-agent hangs e.g.

2020-11-17T22:22:00.8644756Z   selenium-standalone installation finished
2020-11-17T22:22:00.8645075Z   -----
2020-11-17T22:22:00.8796786Z   Done in 10.58s.
2020-11-17T22:22:00.8982232Z   Running tests: F:\workspace\_work\1\s\src\Components\test\E2ETest\bin\Release\net6.0\Microsoft.AspNetCore.Components.E2ETests.dll [net6.0|x64]
2020-11-18T00:49:46.9697144Z Attempting to cancel the build...

and the Blazor template test failures e.g.

    Templates.Test.BlazorServerTemplateTest.BlazorServerTemplateWorks_IndividualAuth(useLocalDB: True) [FAIL]
      System.InvalidOperationException : Couldn't create a Selenium remote driver client. The server is irresponsive
      ---- System.InvalidOperationException : session not created: This version of ChromeDriver only supports Chrome version 85
Build info: version: '3.141.5', revision: 'd54ebd709a', time: '2018-11-06T11:58:47'
System info: host: 'a00010X', ip: '10.0.0.6', os.name: 'Windows Server 2016', os.arch: 'amd64', os.version: '10.0', java.version: '11.0.3'
Driver info: driver.version: unknown
remote stacktrace: Backtrace:
	Ordinal0 [0x00CDD383+3134339]
	Ordinal0 [0x00BCA171+2007409]
	Ordinal0 [0x00A6AEE8+569064]
	Ordinal0 [0x009F139F+70559]
	Ordinal0 [0x009ECC63+52323]
	Ordinal0 [0x00A10DFC+200188]
	Ordinal0 [0x00A10C1D+199709]
	Ordinal0 [0x00A0EB0B+191243]
	Ordinal0 [0x009F2E77+77431]
	Ordinal0 [0x009F3E3E+81470]
	Ordinal0 [0x009F3DC9+81353]
	Ordinal0 [0x00BE0CD9+2100441]
	GetHandleVerifier [0x00E4B75A+1396954]
	GetHandleVerifier [0x00E4B3D9+1396057]
	GetHandleVerifier [0x00E57126+1444518]
	GetHandleVerifier [0x00E4BCE8+1398376]
	Ordinal0 [0x00BD7F51+2064209]
	Ordinal0 [0x00BE22EB+2106091]
	Ordinal0 [0x00BE2411+2106385]
	Ordinal0 [0x00BF49C4+2181572]
	BaseThreadInitThunk [0x74B80419+25]
	RtlGetAppContainerNamedObjectPath [0x775566DD+237]
	RtlGetAppContainerNamedObjectPath [0x775566AD+189]
 (SessionNotCreated)
      Stack Trace:
        /_/src/Shared/E2ETesting/BrowserFixture.cs(210,0): at Microsoft.AspNetCore.E2ETesting.BrowserFixture.CreateBrowserAsync(String context, ITestOutputHelper output)
        /_/src/Shared/E2ETesting/BrowserTestBase.cs(81,0): at Microsoft.AspNetCore.E2ETesting.BrowserTestBase.InitializeBrowser(String isolationContext)
        /_/src/Shared/E2ETesting/BrowserTestBase.cs(68,0): at Microsoft.AspNetCore.E2ETesting.BrowserTestBase.InitializeAsync(String isolationContext)
        ----- Inner Stack Trace -----
           at OpenQA.Selenium.Remote.RemoteWebDriver.UnpackAndThrowOnError(Response errorResponse)
           at OpenQA.Selenium.Remote.RemoteWebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
           at OpenQA.Selenium.Remote.RemoteWebDriver.StartSession(ICapabilities desiredCapabilities)
           at OpenQA.Selenium.Remote.RemoteWebDriver..ctor(ICommandExecutor commandExecutor, ICapabilities desiredCapabilities)
           at OpenQA.Selenium.Remote.RemoteWebDriver..ctor(Uri remoteAddress, ICapabilities desiredCapabilities, TimeSpan commandTimeout)
           at Microsoft.AspNetCore.E2ETesting.BrowserFixture.CreateBrowserAsync(String context, ITestOutputHelper output)
      Output:
        Error initializing RemoteWebDriver: session not created: This version of ChromeDriver only supports Chrome version 85

@captainsafia

Copy link
Copy Markdown
Contributor Author

@dougbu Yes. From what I saw with this build, the first commit fixes the hangs and the third commit fixers the Blazor template issues.

@BrennanConroy
BrennanConroy merged commit f47a646 into master Nov 19, 2020
@BrennanConroy
BrennanConroy deleted the safia/selenium-bump branch November 19, 2020 02:43
@JunTaoLuo

Copy link
Copy Markdown
Contributor

@captainsafia can you also backport this fix to 5.0? I'm seeing it fail there as well, e.g. #27855

@BrennanConroy

Copy link
Copy Markdown
Member

Is this going to be a constant problem for previous releases? If so, we might need to look into better solutions that don't rely on machine state?

@captainsafia

Copy link
Copy Markdown
Contributor Author

Backport to release/5.0 above.

Is this going to be a constant problem for previous releases? If so, we might need to look into better solutions that don't rely on machine state?

Hopefully not, I think things should stabilize once a non-alpha version of the Selenium drivers is out.

captainsafia pushed a commit that referenced this pull request Nov 20, 2020
* Bump Selenium dependency versions (#27947)
* Fix up package references for Selenium deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants