Skip to content

Update .NET SDK to 9.0.100-preview.3.24161.2#54483

Merged
JamesNK merged 5 commits into
mainfrom
update-dotnet-sdk-9.0.100-preview.3.24161.2
Mar 12, 2024
Merged

Update .NET SDK to 9.0.100-preview.3.24161.2#54483
JamesNK merged 5 commits into
mainfrom
update-dotnet-sdk-9.0.100-preview.3.24161.2

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Updates the .NET SDK to version 9.0.100-preview.3.24161.2, which also updates the .NET runtime from version 9.0.0-preview.2.24109.4 to version 9.0.0-preview.3.24160.3.

This pull request was auto-generated by GitHub Actions.

Update .NET SDK to version 9.0.100-preview.3.24161.2.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot requested review from a team and wtgodbe as code owners March 11, 2024 12:07
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 11, 2024
Copy link
Copy Markdown
Contributor

@dotnet-policy-service dotnet-policy-service Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving SDK update.

@eerhardt
Copy link
Copy Markdown
Member

@wtgodbe - why does the bot close and open new PRs every week? It makes tracking the issues a lot harder.

@martincostello
Copy link
Copy Markdown
Member

It's the default behaviour of my action to prevent unmerged PRs piling up. If that's not desired, it can be turned off by setting close-superseded: false.

Comment on lines -170 to -174
if (buffer == null)
{
throw new ArgumentNullException(nameof(buffer));
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Span can't be null. I looked at other TextReader implementations and they all no-op and return a read count of 0. Removed this check.

@github-actions github-actions Bot requested a review from javiercn as a code owner March 12, 2024 06:02
@github-actions github-actions Bot requested review from a team and mgravell as code owners March 12, 2024 06:20
mgravell
mgravell previously approved these changes Mar 12, 2024
@JamesNK JamesNK merged commit e8a7ee5 into main Mar 12, 2024
@JamesNK JamesNK deleted the update-dotnet-sdk-9.0.100-preview.3.24161.2 branch March 12, 2024 12:44
@dotnet-policy-service dotnet-policy-service Bot added this to the 9.0-preview3 milestone Mar 12, 2024
@eerhardt
Copy link
Copy Markdown
Member

It's the default behaviour of my action to prevent unmerged PRs piling up. If that's not desired, it can be turned off by setting close-superseded: false.

Does that also stop a new PR from being opened? Why not just push to the existing PR? That's how maestro updates work.

@martincostello
Copy link
Copy Markdown
Member

It won't stop a new PR if there's a newer SDK version available, but it doesn't currently support pushing over the top like with Maestro. I wouldn't be against pull requests to add that functionality though 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants