Fix components-e2e logging issues#54556
Merged
Merged
Conversation
Member
Author
|
cc @nohwnd - it looks like the exception originates from here. Do you think this may be due to the changes in microsoft/vstest#4877? |
wtgodbe
approved these changes
Mar 15, 2024
3 tasks
Member
|
@MackinnonBuck I am having a look, I will put more info in this issue if needed microsoft/vstest#4938. The log size increase is because we are writing all captured outputs from passed tests. This is different from before, where by default we don't write passed tests at all. I though this would be useful, but its probably more problems than gains, will revert. Then index problem I will have to debug, some info is missing there, and the code is not particularly robust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #54483 was merged, logs for the
components-e2epipeline has increased to 600MB+ in size on successful runs. Furthermore, there have been multiple recent failures in that pipeline with the following stack trace:Disabling the new TerminalLogger (which is on by default in .NET 9) seems to have resolved both the log size and test pipeline failure issues.