[master] Update dependencies from dotnet/corefx

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/corefx

• Build: 20190617.11
• Date Produced: 6/18/2019 12:15 AM
• Commit: 422e295955841aa2d87d41812e7eef1a755f1e0e
• Branch: refs/heads/master
• Updates:
  • System.Windows.Extensions -> 4.6.0-preview7.19317.11
  • System.CodeDom -> 4.6.0-preview7.19317.11
  • Microsoft.NETCore.Platforms -> 3.0.0-preview7.19317.11
  • Microsoft.NETCore.Targets -> 3.0.0-preview7.19317.11
  • Microsoft.Private.CoreFx.NETCoreApp -> 4.6.0-preview7.19317.11
  • Microsoft.Win32.Registry -> 4.6.0-preview7.19317.11
  • Microsoft.Win32.SystemEvents -> 4.6.0-preview7.19317.11
  • Microsoft.Windows.Compatibility -> 3.0.0-preview7.19317.11
  • System.Configuration.ConfigurationManager -> 4.6.0-preview7.19317.11
  • System.Resources.Extensions -> 4.6.0-preview7.19317.11
  • System.Security.AccessControl -> 4.6.0-preview7.19317.11
  • System.Security.Cryptography.Cng -> 4.6.0-preview7.19317.11
  • System.Security.Cryptography.Pkcs -> 4.6.0-preview7.19317.11
  • System.Security.Cryptography.ProtectedData -> 4.6.0-preview7.19317.11
  • System.Security.Cryptography.Xml -> 4.6.0-preview7.19317.11
  • System.Security.Permissions -> 4.6.0-preview7.19317.11
  • System.Security.Principal.Windows -> 4.6.0-preview7.19317.11
  • System.Threading.AccessControl -> 4.6.0-preview7.19317.11
  • System.Diagnostics.EventLog -> 4.6.0-preview7.19317.11
  • System.DirectoryServices -> 4.6.0-preview7.19317.11
  • System.Drawing.Common -> 4.6.0-preview7.19317.11
  • System.IO.FileSystem.AccessControl -> 4.6.0-preview7.19317.11
  • System.IO.Packaging -> 4.6.0-preview7.19317.11

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ All Checks Successful Unsuccessful checks: dotnet.core-setup, dotnet.core-setup (Build_Linux_x64_glibc release), dotnet.core-setup (Build_Linux_x64_glibc debug)

[wtgodbe]

Failing on Linux glibc:

EXEC : error : compilation failed for "/root/coresetup/packages/runtime.linux-x64.microsoft.private.corefx.netcoreapp/4.6.0-preview7.19314.2/runtimes/linux-x64/lib/netcoreapp3.0/System.ComponentModel.TypeConverter.dll" (0x8013200c) [/root/coresetup/src/pkg/projects/netcoreapp/src/netcoreapp.depproj]
/root/coresetup/src/pkg/packaging-tools/framework.dependency.targets(321,5): error MSB3073: The command "/root/coresetup/packages/transport.runtime.linux-x64.microsoft.netcore.runtime.coreclr/3.0.0-preview7.19313.1/tools/crossgen @/root/coresetup/bin/obj/linux-x64.Debug/netcoreapp/linux-x64/linux-x64/crossgen/System.ComponentModel.TypeConverter.rsp" exited with code 12. [/root/coresetup/src/pkg/projects/netcoreapp/src/netcoreapp.depproj]

@dagood any idea what's happening here?

[dagood]

Here's the full error from the binlog:

Error compiling
  /root/coresetup/packages/runtime.linux-x64.microsoft.private.corefx.netcoreapp/4.6.0-preview7.19314.2/runtimes/linux-x64/lib/netcoreapp3.0/System.ComponentModel.TypeConverter.dll:
  Cannot compile using the PartialNgen flag because no IBC data was found. (0x8013200C)

RSP file has this:

-readytorun
-in /root/coresetup/packages/runtime.linux-x64.microsoft.private.corefx.netcoreapp/4.6.0-preview7.19314.2/runtimes/linux-x64/lib/netcoreapp3.0/System.ComponentModel.TypeConverter.dll
-out /root/coresetup/bin/linux-x64.Release/crossgen/netcoreapp/linux-x64/runtimes/linux-x64/lib/netcoreapp3.0/System.ComponentModel.TypeConverter.dll
-platform_assemblies_paths /root/coresetup/packages/runtime.linux-x64.microsoft.private.corefx.netcoreapp/4.6.0-preview7.19314.2/runtimes/linux-x64/lib/netcoreapp3.0/:/root/coresetup/packages/transport.runtime.linux-x64.microsoft.netcore.runtime.coreclr/3.0.0-preview7.19313.1/runtimes/linux-x64/lib/netstandard1.0/:/root/coresetup/packages/transport.runtime.linux-x64.microsoft.netcore.runtime.coreclr/3.0.0-preview7.19313.1/runtimes/linux-x64/native/:/root/coresetup/packages/transport.runtime.linux-x64.microsoft.netcore.runtime.coreclr/3.0.0-preview7.19313.1/runtimes/linux-x64/native/:/root/coresetup/packages/runtime.linux-x64.microsoft.private.corefx.netcoreapp/4.6.0-preview7.19314.2/runtimes/linux-x64/lib/netcoreapp3.0/
-JITPath /root/coresetup/packages/transport.runtime.linux-x64.microsoft.netcore.jit/3.0.0-preview7.19313.1/runtimes/linux-x64/native/libclrjit.so

Command:

Exec
    Assembly = Microsoft.Build.Tasks.Core, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
    CommandLineArguments = /root/coresetup/packages/transport.runtime.linux-x64.microsoft.netcore.runtime.coreclr/3.0.0-preview7.19313.1/tools/crossgen @/root/coresetup/bin/obj/linux-x64.Release/netcoreapp/linux-x64/linux-x64/crossgen/System.ComponentModel.TypeConverter.rsp
    Parameters
        Command = /root/coresetup/packages/transport.runtime.linux-x64.microsoft.netcore.runtime.coreclr/3.0.0-preview7.19313.1/tools/crossgen @/root/coresetup/bin/obj/linux-x64.Release/netcoreapp/linux-x64/linux-x64/crossgen/System.ComponentModel.TypeConverter.rsp
        EnvironmentVariables = COMPlus_PartialNGen=1
    Environment Variables passed to tool:
      COMPlus_PartialNGen=1
    Error compiling /root/coresetup/packages/runtime.linux-x64.microsoft.private.corefx.netcoreapp/4.6.0-preview7.19314.2/runtimes/linux-x64/lib/netcoreapp3.0/System.ComponentModel.TypeConverter.dll: Cannot compile using the PartialNgen flag because no IBC data was found. (0x8013200C)
    Microsoft (R) CoreCLR Native Image Generator - Version 4.5.30319.0
    Copyright (c) Microsoft Corporation.  All rights reserved.
    Errors
        EXEC compilation failed for "/root/coresetup/packages/runtime.linux-x64.microsoft.private.corefx.netcoreapp/4.6.0-preview7.19314.2/runtimes/linux-x64/lib/netcoreapp3.0/System.ComponentModel.TypeConverter.dll" (0x8013200c) [/root/coresetup/src/pkg/projects/netcoreapp/src/netcoreapp.depproj]
        /root/coresetup/src/pkg/packaging-tools/framework.dependency.targets(321,5): error MSB3073: The command "/root/coresetup/packages/transport.runtime.linux-x64.microsoft.netcore.runtime.coreclr/3.0.0-preview7.19313.1/tools/crossgen @/root/coresetup/bin/obj/linux-x64.Release/netcoreapp/linux-x64/linux-x64/crossgen/System.ComponentModel.TypeConverter.rsp" exited with code 12. [/root/coresetup/src/pkg/projects/netcoreapp/src/netcoreapp.depproj]

Somewhat recently, this was explicitly turned into an error: dotnet/coreclr#24557. Not sure why it would show up on a CoreFX update PR...

[dagood]

I see #5252 originally added this:

core-setup/src/pkg/packaging-tools/framework.dependency.targets

Lines 309 to 315 in ff7bf43

	<!-- Measurements show that doing partial crossgen on these assemblies captures a lot of the potential size saving. -->
	<PropertyGroup Condition="'$(OSGroup)' == 'Linux'">
	<_partialCrossgenFlag Condition="'%(_filesToCrossGen.FileName)' == 'System.ComponentModel.TypeConverter'">1</_partialCrossgenFlag>
	<_partialCrossgenFlag Condition="'%(_filesToCrossGen.FileName)' == 'System.Linq.Expressions'">1</_partialCrossgenFlag>
	<_partialCrossgenFlag Condition="'%(_filesToCrossGen.FileName)' == 'System.Private.DataContractSerialization'">1</_partialCrossgenFlag>
	<_partialCrossgenFlag Condition="'%(_filesToCrossGen.FileName)' == 'System.Private.Xml'">1</_partialCrossgenFlag>
	</PropertyGroup>

@MichalStrehovsky, @brianrob, is this still true? Is the right change to stop doing partial crossgen in Core-Setup because crossgen no longer allows it without IBC data?

[dagood]

Not sure why it would show up on a CoreFX update PR...

I see in dotnet/coreclr#24557 there's a longer message that might explain this:

During crossgen compilation, the PartialNgen flag was set, but no IBC data was found in the resources section of the input image, and no IBC file was externally provided.

Maybe CoreFX stopped including IBC data? (Infra issue?)

[MichalStrehovsky]

Maybe CoreFX stopped including IBC data? (Infra issue?)

Yes, seems to be it: dotnet/corefx#38343 (comment). Thanks for root causing it @dagood!

[dagood]

No problem, and sorry if you had to dig around at all because I didn't link back to that here.

A fix was just merged, so this PR should get a good update after it goes through: dotnet/corefx#38593.

[dagood]

Looks like we got the IBC data fix--the Linux leg isn't hitting that particular issue anymore. Thanks @ViktorHofer!

---

CI is still red, it looks like it's because we got a new failure with 1f066d8, which took dotnet/corefx@e1eb561...df5bb8e, dotnet/corefx#38405:

Duplicate type System.Xaml.Permissions.XamlAccessLevel in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Xaml.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Xaml.Permissions.XamlLoadPermission in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Xaml.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Security.Permissions.MediaPermissionAudio in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\WindowsBase.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Security.Permissions.MediaPermissionVideo in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\WindowsBase.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Security.Permissions.MediaPermissionImage in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\WindowsBase.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Security.Permissions.MediaPermission in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\WindowsBase.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Security.Permissions.MediaPermissionAttribute in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\WindowsBase.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Security.Permissions.WebBrowserPermissionLevel in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\WindowsBase.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Security.Permissions.WebBrowserPermission in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\WindowsBase.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]
Duplicate type System.Security.Permissions.WebBrowserPermissionAttribute in both
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\WindowsBase.dll and
  D:\a\1\s\bin\win-x64.Release\crossgen\windowsdesktop\win-x64\runtimes\win-x64\lib\netcoreapp3.0\System.Security.Permissions.dll. [D:\a\1\s\src\pkg\projects\windowsdesktop\pkg\Microsoft.WindowsDesktop.App.pkgproj]

@vatsan-madhavan @ojhad @ericstj, do we need to coordinate taking a new WPF and CoreFX version at the same time or something like that?

[ericstj]

You can temporarily suppress those checks until WPF removes the types. It means a couple builds where using the types will hit a compiler error, but that's not likely to impact people since these are legacy types. We should have WPF clean up ASAP, though.

Set the IgnoredDuplicateType items

core-setup/src/pkg/packaging-tools/framework.packaging.targets

Line 476 in 98fe009

IgnoredTypes="@(IgnoredDuplicateType)" />

[dotnet-maestro]

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

• ✔️ All Checks Successful Succeeded - Successful checks: dotnet.core-setup, dotnet.core-setup (Build_Windows_x86 release), dotnet.core-setup (Build_Windows_x86 debug), dotnet.core-setup (Build_Windows_x64 release), dotnet.core-setup (Build_Windows_Arm64 release), dotnet.core-setup (Build_Windows_x64 debug), dotnet.core-setup (Build_Windows_Arm64 debug), dotnet.core-setup (Build_Windows_Arm release), dotnet.core-setup (Build_OSX release), dotnet.core-setup (Build_Windows_Arm debug), dotnet.core-setup (Build_OSX debug), dotnet.core-setup (Build_Linux_x64_glibc release), dotnet.core-setup (Build_Linux_x64_Rhel6 release), dotnet.core-setup (Build_Linux_x64_glibc debug), dotnet.core-setup (Build_Linux_x64_Rhel6 debug), dotnet.core-setup (Build_Linux_x64_Alpine36 release), dotnet.core-setup (Build_Linux_Arm64_Alpine37 release), dotnet.core-setup (Build_Linux_x64_Alpine36 debug), dotnet.core-setup (Build_Linux_Arm64_Alpine37 debug), dotnet.core-setup (Build_Linux_Arm release), dotnet.core-setup (Build_Linux_Arm64 release), dotnet.core-setup (Build_Linux_Arm64 debug), dotnet.core-setup (Build_Linux_Arm debug)