Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix leg configurations in official builds and converge redhat6 with linux - #38593

Merged
ViktorHofer merged 2 commits into
dotnet:masterfrom
ViktorHofer:YamlOfficialFix
Jun 17, 2019
Merged

Fix leg configurations in official builds and converge redhat6 with linux#38593
ViktorHofer merged 2 commits into
dotnet:masterfrom
ViktorHofer:YamlOfficialFix

Conversation

@ViktorHofer

@ViktorHofer ViktorHofer commented Jun 17, 2019

Copy link
Copy Markdown
Member

Fixes #38343 (comment)

Thanks @dagood for letting me know. The configuration in the fullMatrix section was indeed wrong.

Other changes:

  • Publish test artifacts on redhat6
  • Move redhat6 into linux.yml

@ViktorHofer ViktorHofer changed the title Fix leg configurations in official builds Fix leg configurations in official builds and converge redhat6 with linux Jun 17, 2019

@dagood dagood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ViktorHofer
ViktorHofer merged commit c7178a3 into dotnet:master Jun 17, 2019
@ViktorHofer
ViktorHofer deleted the YamlOfficialFix branch June 17, 2019 14:55
@ViktorHofer

Copy link
Copy Markdown
Member Author

Sorry for the inconvenience. Please let me know if that fixes the break.

Comment thread eng/pipelines/linux.yml
_buildExtraArguments: /p:RuntimeOS=rhel.6 /p:PortableBuild=false
_dockerContainer: rhel6_container
_helixQueues: $(redhatHelixQueue)
_publishTests: ${{ parameters.fullMatrix }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set to false, no? We didn't use to publish test artifacts of RedHat on official builds. I don't expect coreclr/mono running corefx tests on RedHat.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect coreclr/mono running corefx tests on RedHat.

My impression was that at least Mono was going to expand their test platform matrix. @BruceForstall any plans for RedHat?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, corefx-in-coreclr-repo testing is planned to test a minimum of platforms, since we expect to get almost all the coverage benefits from any individual Linux (probably will just do Ubuntu 1804), and testing on additional platforms adds cost and very little benefit.

@karelz karelz added this to the 3.0 milestone Jul 16, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Fix leg configurations in official builds and converge redhat6 with linux

Commit migrated from dotnet/corefx@c7178a3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants