Fix leg configurations in official builds and converge redhat6 with linux - #38593
Conversation
|
Sorry for the inconvenience. Please let me know if that fixes the break. |
| _buildExtraArguments: /p:RuntimeOS=rhel.6 /p:PortableBuild=false | ||
| _dockerContainer: rhel6_container | ||
| _helixQueues: $(redhatHelixQueue) | ||
| _publishTests: ${{ parameters.fullMatrix }} |
There was a problem hiding this comment.
This should be set to false, no? We didn't use to publish test artifacts of RedHat on official builds. I don't expect coreclr/mono running corefx tests on RedHat.
There was a problem hiding this comment.
I don't expect coreclr/mono running corefx tests on RedHat.
My impression was that at least Mono was going to expand their test platform matrix. @BruceForstall any plans for RedHat?
There was a problem hiding this comment.
Currently, corefx-in-coreclr-repo testing is planned to test a minimum of platforms, since we expect to get almost all the coverage benefits from any individual Linux (probably will just do Ubuntu 1804), and testing on additional platforms adds cost and very little benefit.
Fix leg configurations in official builds and converge redhat6 with linux Commit migrated from dotnet/corefx@c7178a3
Fixes #38343 (comment)
Thanks @dagood for letting me know. The configuration in the fullMatrix section was indeed wrong.
Other changes: