This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix version info missing from native binaries - #7864
Merged
Conversation
Allow the SDK to restore SourceLink and find its MSBuild props and targets files. These are used to fetch Git information. Use Arcade-generated '_version.c'. The new '_version.c' is identical to the old 'version.cpp'. The host build.sh generated an empty 'version.cpp' when it doesn't already exist at the specified path, which caused the "No version information" message to be included.
MichaelSimons
approved these changes
Aug 27, 2019
Member
Author
|
For reference, on Windows: On Linux: ( |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Allow the SDK to restore SourceLink and find its MSBuild props and targets files. These are used to fetch Git information. Use Arcade-generated '_version.c'. The new '_version.c' is identical to the old 'version.cpp'. The host build.sh generated an empty 'version.cpp' when it doesn't already exist at the specified path, which caused the "No version information" message to be included. Commit migrated from dotnet/core-setup@bac3b0d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/dotnet/core-setup/issues/7635. To be ported to 3.0: it's an infra regression.
Allow the SDK to restore SourceLink and find its MSBuild props and targets files. These are used to fetch Git information.
Use Arcade-generated
_version.c. The new_version.cis identical to the oldversion.cpp. The hostbuild.shgenerated an emptyversion.cppwhen it doesn't already exist at the specified path, which caused the "No version information" message to be included.