Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix version info missing from native binaries - #7864

Merged
dagood merged 1 commit into
dotnet:masterfrom
dagood:native-version/master
Aug 27, 2019
Merged

Fix version info missing from native binaries#7864
dagood merged 1 commit into
dotnet:masterfrom
dagood:native-version/master

Conversation

@dagood

@dagood dagood commented Aug 27, 2019

Copy link
Copy Markdown
Member

For https://github.com/dotnet/core-setup/issues/7635. To be ported to 3.0: it's an infra regression.

Allow the SDK to restore SourceLink and find its MSBuild props and targets files. These are used to fetch Git information.

Use Arcade-generated _version.c. The new _version.c is identical to the old version.cpp. The host build.sh generated an empty version.cpp when it doesn't already exist at the specified path, which caused the "No version information" message to be included.

Allow the SDK to restore SourceLink and find its MSBuild props and targets files. These are used to fetch Git information.

Use Arcade-generated '_version.c'. The new '_version.c' is identical to the old 'version.cpp'. The host build.sh generated an empty 'version.cpp' when it doesn't already exist at the specified path, which caused the "No version information" message to be included.
@dagood

dagood commented Aug 27, 2019

Copy link
Copy Markdown
Member Author

For reference, on Windows:

#> (ls .\artifacts\bin\win-x64.Debug\corehost\*.dll).VersionInfo.ProductVersion
42,42,42,42424 @Commit: f35878b35101b653bef9f3dd308b314d1bf481b7
42,42,42,42424 @Commit: f35878b35101b653bef9f3dd308b314d1bf481b7
42,42,42,42424 @Commit: f35878b35101b653bef9f3dd308b314d1bf481b7
42,42,42,42424 @Commit: f35878b35101b653bef9f3dd308b314d1bf481b7
42,42,42,42424 @Commit: f35878b35101b653bef9f3dd308b314d1bf481b7
42,42,42,42424 @Commit: f35878b35101b653bef9f3dd308b314d1bf481b7

On Linux:

#> strings artifacts/bin/linux-x64.Debug/corehost/* | grep '@('
@(#)Version 42.42.42.42424 @Commit: 42e0645857c2d0e96103412c9c304dc4ce867252
@(#)Version 42.42.42.42424 @Commit: 42e0645857c2d0e96103412c9c304dc4ce867252
@(#)Version 42.42.42.42424 @Commit: 42e0645857c2d0e96103412c9c304dc4ce867252
@(#)Version 42.42.42.42424 @Commit: 42e0645857c2d0e96103412c9c304dc4ce867252
@(#)Version 42.42.42.42424 @Commit: 42e0645857c2d0e96103412c9c304dc4ce867252

(42 is Arcade for "dev build", my Linux build commit starting with 42 is a coincidence.)

@dagood
dagood merged commit bac3b0d into dotnet:master Aug 27, 2019
@dagood
dagood deleted the native-version/master branch August 27, 2019 18:18
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Allow the SDK to restore SourceLink and find its MSBuild props and targets files. These are used to fetch Git information.

Use Arcade-generated '_version.c'. The new '_version.c' is identical to the old 'version.cpp'. The host build.sh generated an empty 'version.cpp' when it doesn't already exist at the specified path, which caused the "No version information" message to be included.

Commit migrated from dotnet/core-setup@bac3b0d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants