[release/3.0] Fix version info missing from native binaries

[dagood]

Description

For https://github.com/dotnet/core-setup/issues/7635. Ports #7864 to release/3.0.

Adds the expected product version and Git info to native binaries.

Customer Impact

Without this, devs who inspect the native host binaries to figure out where they came from will instead see a message like 3,0,19,40809 @Commit: unknown or @(#)No version information produced.

With this, the message contains the version and commit hash.

Regression?

Yes, this worked before the migration to the Arcade SDK.

Risk

Low. With src/corehost/build.proj now depending a little more on the Arcade SDK, there may be undetected changes, however the project is a thin wrapper around a shell script, so this seems unlikely.

@vitek-karas @elinor-fung

[vatsan-madhavan]

Does this add a full version resource to the binaries and effectively pass the test implied by this program? WPF had similar issues (missing version resources) and we realized that it was going to break bucketizing in Watson - so we also took a fix in 3.0 GA.

// Add Microsoft.Diagnostics.Runtime NuGet package.
using Microsoft.Diagnostics.Runtime.Utilities;
using System;
using System.IO;
using System.Linq;


namespace ValidateVersion
{
    class Program
    {
        static int Main(string[] args)
        {
            string tmpDirectory = Path.Combine(Path.GetTempPath(), "test_delete");

            bool success = false;

            if (args.Length > 0 && File.Exists(args[0]))
            {
                string localPath = args[0];
                using (var file = File.OpenRead(localPath))
                {
                    PEImage img = new PEImage(file);
                    bool hasVersion = img.Resources.Children.Where(c => c.Name == "Version").Count() > 0;

                    if (hasVersion)
                    {
                        //Console.WriteLine($"SUCCESS: {localPath}");
                        Console.Write(".");
                        success = true;
                    }
                    else
                    {
                        Console.WriteLine();
                        Console.WriteLine($"FAIL: {localPath}");
                    }

                    // Console.WriteLine("Resource nodes:");
                    // PrintResource(img.Resources, 1);
                }

                try
                {
                    Directory.Delete(tmpDirectory, recursive: true);
                }
                catch
                {
                }
            }

            return success ? 1 : 0;
        }

        private static void PrintResource(ResourceEntry res, int index = 0)
        {
            Console.Write(new string(' ', index * 4));
            Console.WriteLine(res.Name);
     
            foreach (var item in res.Children)
                PrintResource(item, index + 1);
        }
    }

}

[dagood]

I'm not familiar with what the test implies, but it tells me this when I run it on some new Windows native outputs:

#> ls C:\git\core-setup-arcade\artifacts\bin\win-x64.Debug\corehost\*.dll | %{ dotnet run -- $_ }
SUCCESS: C:\git\core-setup-arcade\artifacts\bin\win-x64.Debug\corehost\comhost.dll
.Resource nodes:
    root
        Version

                ???????????? ???????? ?????????? ?????????????? ??????????????
        RT_MANIFEST

                ???????????? ???????? ?????????? ?????????????? ??????????????
SUCCESS: C:\git\core-setup-arcade\artifacts\bin\win-x64.Debug\corehost\hostfxr.dll
.Resource nodes:
    root
        Version


        RT_MANIFEST


SUCCESS: C:\git\core-setup-arcade\artifacts\bin\win-x64.Debug\corehost\hostpolicy.dll
.Resource nodes:
    root
        Version

                ?????? ???? ?????????
        RT_MANIFEST

                ?????? ???? ?????????
SUCCESS: C:\git\core-setup-arcade\artifacts\bin\win-x64.Debug\corehost\ijwhost.dll
.Resource nodes:
    root
        Version

                ???????????? ???????? ?????????? ?????????????? ??????????????
        RT_MANIFEST

                ???????????? ???????? ?????????? ?????????????? ??????????????
SUCCESS: C:\git\core-setup-arcade\artifacts\bin\win-x64.Debug\corehost\nethost.dll
.Resource nodes:
    root
        Version

                A??????????????
        RT_MANIFEST

                A??????????????
SUCCESS: C:\git\core-setup-arcade\artifacts\bin\win-x64.Debug\corehost\winrthost.dll
.Resource nodes:
    root
        Version

                ???
        RT_MANIFEST

                ???

[vatsan-madhavan]

If it succeeds, then your version resources are embedded and present - it's really just looking the version resource. You can also see it in file explorer properties dialog (details pane), or by opening the binary in Visual Studio and inspecting the resource directly.

[dagood]

I see, yeah, I use (ls C:\git\core-setup-arcade\artifacts\bin\win-x64.Debug\corehost\*.dll).VersionInfo typically to check the values.