This repository was archived by the owner on Jan 23, 2023. It is now read-only.
fix Matrix4x4 + and - operator bugs - #39838
Merged
Merged
Conversation
Member
|
This is a big functional regression, introduced in #31779 for 3.0 (cc: @EgorBo). This needs to be fixed for 3.0. Example: using System;
using System.Numerics;
class Program
{
static void Main()
{
var m0 = new Matrix4x4(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
var m1 = new Matrix4x4(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1);
Console.WriteLine(m0 + m1);
}
}On netcoreapp2.1: On netcoreapp3.0: |
stephentoub
approved these changes
Jul 29, 2019
tannergooding
approved these changes
Jul 29, 2019
Member
|
@danmosemsft, do you want me to backport to release/3.0? |
|
Yes, it sounds like it deserves it. Please include the usual tempalte in the PR https://gist.github.com/danmosemsft/348cbe83ccd7ae0e87c5598223be1380 and tag ask-mode. |
Member
|
This PR went into master - fixing milestone to 5.0. |
wtgodbe
pushed a commit
that referenced
this pull request
Aug 7, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* fix Matrix4x4 + and - operator bugs * fix Add() and Subtract() tests Commit migrated from dotnet/corefx@b5e9310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new SSE versions of the operators add/subtract
value1to/from itself. The tests were set up with the same value for both arguments, so they didn't catch the issue. Fixed both.