This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0] fix Matrix4x4 + and - operator bugs (#39838) - #39889
Merged
Conversation
* fix Matrix4x4 + and - operator bugs * fix Add() and Subtract() tests
Member
Author
|
CC. @stephentoub, @danmosemsft I'm also going to log an issue tracking us reviewing the existing numeric tests to validate we don't have other places where the lhs/rhs inputs are only always the same. |
Member
Author
|
Logged https://github.com/dotnet/corefx/issues/39890 to track auditing the remaining tests. |
Member
|
tactics approved - wait to merge for @wtgodbe go ahead. |
Member
Author
|
@wtgodbe, do you have an ETA on when this can be merged? |
Member
|
Currently I'm targeting Monday |
karelz
changed the title
Member
|
@tannergooding please link the PR you are porting in future (see my edits to top post) - it required some effort to find this one and confirm we didn't lose track of the port request. Thanks! |
|
still waiting on branch |
Member
|
Branch is open, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #39838 to release/3.0
Description
#31779 brought a perf improvement to the
Matrix4x4addition and subtraction operators, but also introduced a functional regression due to using the left-hand side variable twice.Customer Impact
Customers using the addition or subtraction operators on
Matrix4x4will compute the wrong resultRegression?
Yes, as per the description.
Risk
Low. The tests are being updated to use different values for the left and right hand side inputs to validate this stays correct and we don't accidentally introduce bugs like this in the future.