This repository was archived by the owner on Jan 23, 2023. It is now read-only.
set _requestQueueBoundHandle to null after disposing - #40466
Merged
Conversation
|
|
||
| HttpListenerContext context = listener.GetContext(); | ||
| HttpListenerResponse response = context.Response; | ||
| response.OutputStream.Write(System.Text.Encoding.UTF8.GetBytes(content)); |
There was a problem hiding this comment.
Not using GetContextAsync() and WriteAsync()?
Member
Author
There was a problem hiding this comment.
I could write one more variant. But for this test I wanted to cover the synchronous path. As far as the write, I don't think it matters. Since it is so small, it will go straight to socket buffer AFAIK without much .NET processing.
| clientTask = client.GetStringAsync(factory.ListeningUrl); | ||
| context = listener.GetContext(); | ||
| response = context.Response; | ||
| response.OutputStream.Write(System.Text.Encoding.UTF8.GetBytes(content)); |
There was a problem hiding this comment.
Not using GetContextAsync() and WriteAsync()?
stephentoub
reviewed
Aug 22, 2019
stephentoub
reviewed
Aug 22, 2019
stephentoub
reviewed
Aug 22, 2019
stephentoub
approved these changes
Aug 26, 2019
scalablecory
added a commit
that referenced
this pull request
Sep 3, 2019
This reverts commit 40949c4.
scalablecory
added a commit
that referenced
this pull request
Sep 3, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…0466) * set _requestQueueBoundHandle to null after disposing * remove extra spaces * feedback from review Commit migrated from dotnet/corefx@40949c4
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…/corefx#40783) * Revert "set _requestQueueBoundHandle to null after disposing (dotnet/corefx#40466)", but keep tests around (disabled re: 39552) This reverts commit dotnet/corefx@40949c4. Commit migrated from dotnet/corefx@7a668f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, Start()/Stop()/Start() sequence should work as expected.
Added two tests for restart.
fixes #39552