This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Revert "set _requestQueueBoundHandle to null after disposing" - #40783
Merged
Conversation
This reverts commit 40949c4.
davidsh
approved these changes
Sep 3, 2019
davidsh
left a comment
davidsh
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I would be ok if you kept the new tests and just disabled them against the original issue.
Contributor
|
fyi. 'HttpListener' component is considered as "area-System.Net" and not "area-System.Net.Http" |
Author
|
Good idea :) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…/corefx#40783) * Revert "set _requestQueueBoundHandle to null after disposing (dotnet/corefx#40466)", but keep tests around (disabled re: 39552) This reverts commit dotnet/corefx@40949c4. Commit migrated from dotnet/corefx@7a668f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #40466
This fix is not handling outstanding I/Os correctly and causing a number of test failures. Needs a deeper look to determine what the actual fix should be.