This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Change IPipe* to abstract classes - #2064
Merged
Merged
Conversation
Contributor
Author
|
@dotnet-bot test Innerloop Ubuntu16.04 Release Build and Test |
halter73
approved these changes
Jan 23, 2018
halter73
left a comment
halter73
left a comment
Member
There was a problem hiding this comment.
Eventually I would like to move more implementation into the reader and writer if possible, but I get that there's a lot of shared state there.
ahsonkhan
reviewed
Jan 25, 2018
| VisualStudioVersion = 15.0.27130.2020 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{5E7EB061-B9BC-4DA2-B5E5-859AA7C67695}" | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "MultiSegmentBytesReaderNumbers", "MultiSegmentBytesReaderNumbers", "{5E7EB061-B9BC-4DA2-B5E5-859AA7C67695}" |
Contributor
There was a problem hiding this comment.
I don't understand this change. Was it intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipe class is now
ResetablePipe