Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

Adding back the byteOffset to OwnedMemory Pin - #2067

Merged
ahsonkhan merged 1 commit into
dotnet:masterfrom
ahsonkhan:FixPin
Jan 25, 2018
Merged

Adding back the byteOffset to OwnedMemory Pin#2067
ahsonkhan merged 1 commit into
dotnet:masterfrom
ahsonkhan:FixPin

Conversation

@ahsonkhan

@ahsonkhan ahsonkhan commented Jan 25, 2018

Copy link
Copy Markdown
Contributor

Supersedes #2063

Reacting to changes from dotnet/corefx#25770

cc @dotnet/corefxlab-contrib, @pakrym, @davidfowl

@ahsonkhan ahsonkhan mentioned this pull request Jan 25, 2018
Merged
@ahsonkhan

ahsonkhan commented Jan 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@dotnet-bot test Innerloop OSX10.12 Release Build and Test

https://ci.dot.net/job/dotnet_corefxlab/job/master/job/osx10.12_release_prtest/1428/consoleFull#-852907932d31e50d-1517-49fc-92b3-2ca637122019

[xUnit.net 00:00:25.8478100]     System.IO.Pipelines.Tests.ReadableBufferReaderFacts+OwnedMemory.CopyToLargerBufferWorks [FAIL]
18:22:55 [xUnit.net 00:00:25.8492760]       Assert.True() Failure
18:22:55 [xUnit.net 00:00:25.8494040]       Expected: True
18:22:55 [xUnit.net 00:00:25.8494680]       Actual:   False
18:22:55 [xUnit.net 00:00:25.8508200]       Stack Trace:
18:22:55 [xUnit.net 00:00:25.8672420]         /Users/dotnet-bot/j/workspace/dotnet_corefxlab/master/osx10.12_release_prtest/tests/System.Buffers.Primitives.Tests/ReadableBufferReaderFacts.cs(318,0): at System.IO.Pipelines.Tests.ReadableBufferReaderFacts.CopyToLargerBufferWorks()
18:22:55 Failed   System.IO.Pipelines.Tests.ReadableBufferReaderFacts+OwnedMemory.CopyToLargerBufferWorks
18:22:55 Error Message:
18:22:55  Assert.True() Failure
18:22:55 Expected: True
18:22:55 Actual:   False
18:22:55 Stack Trace:
18:22:55    at System.IO.Pipelines.Tests.ReadableBufferReaderFacts.CopyToLargerBufferWorks() in /Users/dotnet-bot/j/workspace/dotnet_corefxlab/master/osx10.12_release_prtest/tests/System.Buffers.Primitives.Tests/ReadableBufferReaderFacts.cs:line 318
18:23:10 [xUnit.net 00:00:41.0739380]   Finished:    System.Buffers.Primitives.Tests
18:23:11 
18:23:11

@KrzysztofCwalina, any updates on this issue? #2062

@ahsonkhan
ahsonkhan merged commit 1183c2a into dotnet:master Jan 25, 2018
@ahsonkhan ahsonkhan mentioned this pull request Jan 25, 2018
Closed
@ahsonkhan
ahsonkhan deleted the FixPin branch January 25, 2018 02:58
ahsonkhan
ahsonkhan commented Jan 25, 2018
View reviewed changes
Comment thread src/System.IO.Pipelines.Networking.Windows.RIO/Internal/Pool/MemoryPoolBlock.cs
public override MemoryHandle Pin()
public override MemoryHandle Pin(int byteOffset = 0)
{
if (IsDisposed) RioPipelinesThrowHelper.ThrowObjectDisposedException(nameof(RioMemoryPoolBlock));

@ahsonkhan ahsonkhan Jan 25, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note the removal of this check, since it was redundant with the check that Retain() already does (here and elsewhere).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ahsonkhan