Skip to content

Enable nullability in provider tests - #38789

Merged
AndriySvyryd merged 1 commit into
mainfrom
issue24427-nrt-2-providers
Aug 12, 2026
Merged

Enable nullability in provider tests#38789
AndriySvyryd merged 1 commit into
mainfrom
issue24427-nrt-2-providers

Conversation

@AndriySvyryd

@AndriySvyryd AndriySvyryd commented Aug 12, 2026

Copy link
Copy Markdown
Member

Part 2 of 5 for #24427. Based on #38788.

Summary

  • Enables nullable analysis across Cosmos, SQLite, SQL Server, OData, cross-store, and HierarchyId tests.
  • Corrects optional provider test model members so NRT annotations do not change EF model semantics.
  • Preserves every pre-existing SQL Server and SQLite AssertSql raw string.
  • Includes the nullable query sorter contract required by provider overrides.

Stack

  1. Enable nullability in benchmarks and core tests #38788
  2. Enable nullability in provider tests #38789 (this PR)
  3. Enable nullability in relational and design tests #38790
  4. Enable nullability in shared specification tests #38791
  5. Enable nullability in shared test sources #38792

Validation

  • Full EFCore.slnx build at this tip: 0 warnings, 0 errors.
  • Encoding-safe SQL baseline audit at the final tip: 136 files with pre-existing baselines, 0 modified or removed baselines.
  • Final functional runs: SQLite 38,414 tests and SQL Server 50,812 tests, both with 0 failures; Cosmos also passes with 0 failures.
  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow the required format
  • Tests for the changes have been added or existing coverage validates the migration
  • Code follows the same patterns and style as existing code in this repo

@AndriySvyryd
AndriySvyryd requested a lite review from Copilot August 12, 2026 21:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Base automatically changed from issue24427-nrt-1-core to main August 12, 2026 21:25
@AndriySvyryd
AndriySvyryd requested a review from wtgodbe as a code owner August 12, 2026 21:25
- Annotate Cosmos, SQLite, SQL Server, OData, and cross-store tests
- Preserve provider model semantics and existing SQL baselines

Part of #24427
@AndriySvyryd
AndriySvyryd force-pushed the issue24427-nrt-2-providers branch from d0b2e88 to 7ddb875 Compare August 12, 2026 21:25
@AndriySvyryd
AndriySvyryd merged commit 312a74a into main Aug 12, 2026
15 checks passed
@AndriySvyryd
AndriySvyryd deleted the issue24427-nrt-2-providers branch August 12, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants