Skip to content

Enable nullability in shared specification tests - #38791

Merged
AndriySvyryd merged 1 commit into
mainfrom
issue24427-nrt-4-specification
Aug 13, 2026
Merged

Enable nullability in shared specification tests#38791
AndriySvyryd merged 1 commit into
mainfrom
issue24427-nrt-4-specification

Conversation

@AndriySvyryd

@AndriySvyryd AndriySvyryd commented Aug 12, 2026

Copy link
Copy Markdown
Member

Part 4 of 5 for #24427. Based on #38790.

Summary

  • Enables nullable analysis throughout shared model, query, update, and test utility infrastructure.
  • Enables NRT in InMemory functional and ASP.NET specification/functional projects.
  • Annotates optional CLR properties and navigations so provider behavior remains unchanged.
  • Keeps all pre-existing assertion invocations semantically intact.

Stack

  1. Enable nullability in benchmarks and core tests #38788
  2. Enable nullability in provider tests #38789
  3. Enable nullability in relational and design tests #38790
  4. Enable nullability in shared specification tests #38791 (this PR)
  5. Enable nullability in shared test sources #38792

Validation

  • Full EFCore.slnx build at this tip: 0 warnings, 0 errors.
  • InMemory functional tests: 28,258 total, 0 failed.
  • Final Roslyn assertion audit: 1,503 changed C# files, 0 missing assertions, 0 parse errors.
  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow the required format
  • Tests for the changes have been added or existing coverage validates the migration
  • Code follows the same patterns and style as existing code in this repo

@AndriySvyryd
AndriySvyryd requested a lite review from Copilot August 12, 2026 21:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

stack merge was automatically disabled August 12, 2026 21:25

Pull Request is not mergeable

@AndriySvyryd
AndriySvyryd force-pushed the issue24427-nrt-4-specification branch from 8dc42aa to 8852019 Compare August 12, 2026 21:25
@AndriySvyryd
AndriySvyryd force-pushed the issue24427-nrt-4-specification branch from 8852019 to afe8576 Compare August 12, 2026 22:03
Base automatically changed from issue24427-nrt-3-relational-design to main August 12, 2026 22:34
- Annotate shared model, query, update, and test utility infrastructure
- Enable nullable analysis in InMemory and ASP.NET functional tests

Part of #24427
@AndriySvyryd
AndriySvyryd force-pushed the issue24427-nrt-4-specification branch from afe8576 to 4e525d0 Compare August 12, 2026 22:34
@AndriySvyryd
AndriySvyryd merged commit 5e88965 into main Aug 13, 2026
15 checks passed
@AndriySvyryd
AndriySvyryd deleted the issue24427-nrt-4-specification branch August 13, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants