Allow setting output and error streams to make CommnadLineApplication… - #142
Merged
Conversation
Author
| public Func<string> LongVersionGetter { get; set; } | ||
| public Func<string> ShortVersionGetter { get; set; } | ||
| public readonly List<CommandLineApplication> Commands; | ||
| public TextWriter Out { get; set; } = Console.Out; |
There was a problem hiding this comment.
Do these need to be public? Could these be passed in as constructor arguments instead?
Author
There was a problem hiding this comment.
All the other switches on this are public, including fields like the one on the line above. Was keeping it consistent.
|
|
1 similar comment
|
|
natemcmaster
pushed a commit
that referenced
this pull request
Nov 16, 2018
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… easier to test.