Skip to content

Allow setting output and error streams to make CommnadLineApplication… #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pranavkm merged 1 commit into from
Aug 31, 2016
Merged

Allow setting output and error streams to make CommnadLineApplication… #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/Microsoft.Extensions.CommandLineUtils/CommandLine/CommandLineApplication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
Expand Down Expand Up @@ -43,6 +44,8 @@ public CommandLineApplication(bool throwOnUnexpectedArg = true)
public Func<string> LongVersionGetter { get; set; }
public Func<string> ShortVersionGetter { get; set; }
public readonly List<CommandLineApplication> Commands;
public TextWriter Out { get; set; } = Console.Out;

@natemcmaster natemcmaster Aug 26, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these need to be public? Could these be passed in as constructor arguments instead?

@pranavkm pranavkm Aug 26, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other switches on this are public, including fields like the one on the line above. Was keeping it consistent.

@natemcmaster natemcmaster Aug 26, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

public TextWriter Error { get; set; } = Console.Error;

public IEnumerable<CommandOption> GetOptions()
{
Expand Down Expand Up @@ -327,7 +330,7 @@ public void ShowHint()
{
if (OptionHelp != null)
{
Console.WriteLine(string.Format("Specify --{0} for a list of available options and commands.", OptionHelp.LongName));
Out.WriteLine(string.Format("Specify --{0} for a list of available options and commands.", OptionHelp.LongName));
}
}

Expand All @@ -339,7 +342,7 @@ public void ShowHelp(string commandName = null)
cmd.IsShowingInformation = true;
}

Console.WriteLine(GetHelpText(commandName));
Out.WriteLine(GetHelpText(commandName));
}

public virtual string GetHelpText(string commandName = null)
Expand Down Expand Up @@ -451,8 +454,8 @@ public void ShowVersion()
cmd.IsShowingInformation = true;
}

Console.WriteLine(FullName);
Console.WriteLine(LongVersionGetter());
Out.WriteLine(FullName);
Out.WriteLine(LongVersionGetter());
}

public string GetFullNameAndVersion()
Expand All @@ -468,8 +471,8 @@ public void ShowRootCommandFullNameAndVersion()
rootCmd = rootCmd.Parent;
}

Console.WriteLine(rootCmd.GetFullNameAndVersion());
Console.WriteLine();
Out.WriteLine(rootCmd.GetFullNameAndVersion());
Out.WriteLine();
}

private void HandleUnexpectedArg(CommandLineApplication command, string[] args, int index, string argTypeName)
Expand Down