[release/2.1] Update branding to 2.1.28 - #3855
Merged
Merged
Conversation
- e.g. `$(MicrosoftNETCoreAppPackageVersion)`
- updated xunit.assert and xunit.extensibility.execution minor versions
- align with xunit package version
wtgodbe
approved these changes
Apr 6, 2021
TanayParikh
approved these changes
Apr 6, 2021
TanayParikh
left a comment
TanayParikh
left a comment
There was a problem hiding this comment.
LGTM, though some tests are failing in the CI.
7 tasks
- set locale consistently on all platforms
- default locale on newer agents is unloved `C.UTF-8`
dougbu
force-pushed
the
dougbu/branding.2.1.28
branch
from
April 7, 2021 20:58
4475e56 to
06e47db
Compare
dougbu
commented
Apr 7, 2021
|
|
||
| // Wait for compaction to complete | ||
| Assert.True(await sem.WaitAsync(TimeSpan.FromSeconds(10))); | ||
| Assert.True(await sem.WaitAsync(TimeSpan.FromSeconds(20))); |
Author
There was a problem hiding this comment.
@BrennanConroy is this a reasonable fix for flakiness in this test class❔ If not you, who should agree or disagree❔
Member
There was a problem hiding this comment.
Seems fine, we've moved to 30 seconds in a lot of places in 3.1 and 5.0.
Personally, I would change the SemaphoreSlime to a CancellationTokenSource.
Author
There was a problem hiding this comment.
Let's get this in to unblock any 2.1.28 fixes. Feel free to improve the tests further in another PR.
ghost
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Update branding to 2.1.27 (#3842) * Update branding to 2.1.27 * Fix patchconfig, baseline val * Update SDK and baseline * [release/2.1] Update branding to 2.1.28 (#3855) * Update branding to 2.1.28 * Bump incoming package patch versions - e.g. `$(MicrosoftNETCoreAppPackageVersion)` - updated xunit.assert and xunit.extensibility.execution minor versions - align with xunit package version * Use Ubuntu 18.04 build agents - set locale consistently on all platforms - default locale on newer agents is unloved `C.UTF-8` * !flaky fix! Double compaction timeouts Co-authored-by: William Godbe <wigodbe@microsoft.com> Co-authored-by: John Luo <johluo@microsoft.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com> Co-authored-by: Sebastien Ros <sebastienros@gmail.com>
ghost
pushed a commit
that referenced
this pull request
Apr 21, 2021
* Update branding to 2.1.27 (#3842) * Update branding to 2.1.27 * Fix patchconfig, baseline val * Update SDK and baseline * [release/2.1] Update branding to 2.1.28 (#3855) * Update branding to 2.1.28 * Bump incoming package patch versions - e.g. `$(MicrosoftNETCoreAppPackageVersion)` - updated xunit.assert and xunit.extensibility.execution minor versions - align with xunit package version * Use Ubuntu 18.04 build agents - set locale consistently on all platforms - default locale on newer agents is unloved `C.UTF-8` * !flaky fix! Double compaction timeouts * [release/2.1] Credentials fix (#3859) - inspired by dotnet/runtime#50230 - cherry-picked from 1594096 * [release/2.1] Bump some versions (#3866) * Move to latest KoreBuild / .NET SDK * Update baselines - did not ship any C# packages in 2.1.27 - re-enable baseline validation * Bump Microsoft.NETCore.App package version Co-authored-by: William Godbe <wigodbe@microsoft.com> Co-authored-by: John Luo <johluo@microsoft.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com> Co-authored-by: Sebastien Ros <sebastienros@gmail.com>
ghost
pushed a commit
that referenced
this pull request
May 5, 2021
* Update branding to 2.1.27 (#3842) * Update branding to 2.1.27 * Fix patchconfig, baseline val * Update SDK and baseline * [release/2.1] Update branding to 2.1.28 (#3855) * Update branding to 2.1.28 * Bump incoming package patch versions - e.g. `$(MicrosoftNETCoreAppPackageVersion)` - updated xunit.assert and xunit.extensibility.execution minor versions - align with xunit package version * Use Ubuntu 18.04 build agents - set locale consistently on all platforms - default locale on newer agents is unloved `C.UTF-8` * !flaky fix! Double compaction timeouts * [release/2.1] Credentials fix (#3859) - inspired by dotnet/runtime#50230 - cherry-picked from 1594096 * [release/2.1] Bump some versions (#3866) * Move to latest KoreBuild / .NET SDK * Update baselines - did not ship any C# packages in 2.1.27 - re-enable baseline validation * Bump Microsoft.NETCore.App package version * Update branding to 2.1.29 (#3870) Co-authored-by: William Godbe <wigodbe@microsoft.com> Co-authored-by: John Luo <johluo@microsoft.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
ghost
pushed a commit
that referenced
this pull request
May 18, 2021
* Update branding to 2.1.27 (#3842) * Update branding to 2.1.27 * Fix patchconfig, baseline val * Update SDK and baseline * [release/2.1] Update branding to 2.1.28 (#3855) * Update branding to 2.1.28 * Bump incoming package patch versions - e.g. `$(MicrosoftNETCoreAppPackageVersion)` - updated xunit.assert and xunit.extensibility.execution minor versions - align with xunit package version * Use Ubuntu 18.04 build agents - set locale consistently on all platforms - default locale on newer agents is unloved `C.UTF-8` * !flaky fix! Double compaction timeouts * [release/2.1] Credentials fix (#3859) - inspired by dotnet/runtime#50230 - cherry-picked from 1594096 * [release/2.1] Bump some versions (#3866) * Move to latest KoreBuild / .NET SDK * Update baselines - did not ship any C# packages in 2.1.27 - re-enable baseline validation * Bump Microsoft.NETCore.App package version * Update branding to 2.1.29 (#3870) * Update baselines * Update SDK Co-authored-by: William Godbe <wigodbe@microsoft.com> Co-authored-by: John Luo <johluo@microsoft.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com> Co-authored-by: Pranav K <prkrishn@hotmail.com>
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(MicrosoftNETCoreAppPackageVersion)