Credentials fix by aik-jahoda · Pull Request #50230 · dotnet/runtime

aik-jahoda · 2021-03-25T10:40:32Z

Replaces credentials and re-password certificates.

ghost · 2021-03-25T10:40:43Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaces credentials and re-password certificates.

Author:	aik-jahoda
Assignees:	-
Labels:	`area-System.Net`
Milestone:	-

…/cred-6.0

ghost · 2021-03-25T22:13:05Z

Hello @danmoseley!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

danmoseley · 2021-03-26T04:18:35Z

Failures are
#50271
#50270
and the xunit bug.

elinor-fung · 2021-03-29T22:21:13Z

With this change, platforms that don't support RC2 (currently only Android, bring-up still in progress) now try to use non-existent certificate files:

runtime/src/libraries/Common/tests/System/Net/Configuration.Certificates.cs

Lines 40 to 43 in aece157

    
           string contosoPfxSuffix = PlatformSupport.IsRC2Supported ? ".pfx" : ".noRC2.pfx"; 
        
           byte[] serverCertificateBytes = File.ReadAllBytes(Path.Combine(TestDataFolder, $"testservereku.contoso.com{contosoPfxSuffix}")); 
        
           byte[] clientCertificateBytes = File.ReadAllBytes(Path.Combine(TestDataFolder, $"testclienteku.contoso.com{contosoPfxSuffix}")); 
        
           byte[] noEKUCertificateBytes = File.ReadAllBytes(Path.Combine(TestDataFolder, $"testnoeku.contoso.com{contosoPfxSuffix}"));

Those files were added in dotnet/runtime-assets#120 and consumed in #49461. It looks like they were not included in dotnet/runtime-assets#124.

@aik-jahoda could you get those certs included in all this credentials re-passwording / suppression work? Or point us at what needs to happen here?

cc @jkoritzinsky @steveisok

aik-jahoda · 2021-03-30T11:53:37Z

@elinor-fung there is a fix in runtime assets: dotnet/runtime-assets#128, I will change package version in runtime once the PR is merged and package published.

- inspired by dotnet/runtime#50230

- inspired by dotnet/runtime#50230 - cherry-picked from 1594096

aik-jahoda · 2021-04-12T09:36:22Z

the runtime now uses the fixed certificates: #51049

* Update branding to 2.1.27 (#3842) * Update branding to 2.1.27 * Fix patchconfig, baseline val * Update SDK and baseline * [release/2.1] Update branding to 2.1.28 (#3855) * Update branding to 2.1.28 * Bump incoming package patch versions - e.g. `$(MicrosoftNETCoreAppPackageVersion)` - updated xunit.assert and xunit.extensibility.execution minor versions - align with xunit package version * Use Ubuntu 18.04 build agents - set locale consistently on all platforms - default locale on newer agents is unloved `C.UTF-8` * !flaky fix! Double compaction timeouts * [release/2.1] Credentials fix (#3859) - inspired by dotnet/runtime#50230 - cherry-picked from 1594096 * [release/2.1] Bump some versions (#3866) * Move to latest KoreBuild / .NET SDK * Update baselines - did not ship any C# packages in 2.1.27 - re-enable baseline validation * Bump Microsoft.NETCore.App package version Co-authored-by: William Godbe <wigodbe@microsoft.com> Co-authored-by: John Luo <johluo@microsoft.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com> Co-authored-by: Sebastien Ros <sebastienros@gmail.com>

* Update branding to 2.1.27 (#3842) * Update branding to 2.1.27 * Fix patchconfig, baseline val * Update SDK and baseline * [release/2.1] Update branding to 2.1.28 (#3855) * Update branding to 2.1.28 * Bump incoming package patch versions - e.g. `$(MicrosoftNETCoreAppPackageVersion)` - updated xunit.assert and xunit.extensibility.execution minor versions - align with xunit package version * Use Ubuntu 18.04 build agents - set locale consistently on all platforms - default locale on newer agents is unloved `C.UTF-8` * !flaky fix! Double compaction timeouts * [release/2.1] Credentials fix (#3859) - inspired by dotnet/runtime#50230 - cherry-picked from 1594096 * [release/2.1] Bump some versions (#3866) * Move to latest KoreBuild / .NET SDK * Update baselines - did not ship any C# packages in 2.1.27 - re-enable baseline validation * Bump Microsoft.NETCore.App package version * Update branding to 2.1.29 (#3870) Co-authored-by: William Godbe <wigodbe@microsoft.com> Co-authored-by: John Luo <johluo@microsoft.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>

Jan Jahoda added 4 commits March 24, 2021 16:57

Port of dotnet/corefx#43051

6e4d109

Shrink suppression file

8741e74

Fix another bugs

bb366bc

Bump System.Net.TestData version

3548198

ghost added the area-System.Net label Mar 25, 2021

aik-jahoda mentioned this pull request Mar 25, 2021

[3.1] Some overlooked credscan fixes dotnet/corefx#43057

Merged

aik-jahoda requested review from danmoseley and wfurt March 25, 2021 13:33

aik-jahoda mentioned this pull request Mar 25, 2021

[5.0] Credscan #50120

Merged

danmoseley approved these changes Mar 25, 2021

View reviewed changes

runfoapp Bot mentioned this pull request Mar 25, 2021

Builds legs getting abandoned due to agent notification issues #35223

Closed

Jan Jahoda and others added 8 commits March 25, 2021 16:21

Fix typo

65bca41

Revert casing in connection string

f634140

Fix connection string case

c9cb32e

more fixes

98435d1

Change suppression messages

73aa55d

Merge remote-tracking branch 'origin/jajahoda/cred-6.0' into jajahoda…

e2007f5

…/cred-6.0

Fix typo

9bfa1b0

Remove false positive

acb3937

danmoseley added the auto-merge label Mar 25, 2021

Dan Moseley added 2 commits March 25, 2021 15:43

Merge branch 'main' into jajahoda/cred-6.0

044614d

Fix usersecrets

7bf1b86

danmoseley merged commit 78f9803 into dotnet:main Mar 26, 2021

aik-jahoda deleted the jajahoda/cred-6.0 branch March 26, 2021 07:40

aik-jahoda mentioned this pull request Mar 30, 2021

Fix android failed build dotnet/runtime-assets#128

Merged

dougbu added a commit to dotnet/extensions that referenced this pull request Apr 8, 2021

Credentials fix

1594096

- inspired by dotnet/runtime#50230

dougbu added a commit to dotnet/extensions that referenced this pull request Apr 8, 2021

Credentials fix

4b601a0

- inspired by dotnet/runtime#50230

dougbu added a commit to dotnet/extensions that referenced this pull request Apr 8, 2021

[release/2.1] Credentials fix

bb01c8d

- inspired by dotnet/runtime#50230 - cherry-picked from 1594096

dougbu mentioned this pull request Apr 8, 2021

[release/2.1] Credentials fix dotnet/extensions#3859

Merged

dougbu added a commit to dotnet/extensions that referenced this pull request Apr 8, 2021

[release/2.1] Credentials fix (#3859)

6d15218

- inspired by dotnet/runtime#50230 - cherry-picked from 1594096

karelz mentioned this pull request May 11, 2021

SyncHttpHandlerTest_AutoRedirect.AllowAutoRedirect_True_ValidateNewMethodUsedOnRedirection failed with "Socket is already connected" on macOS #50271

Closed

ghost locked as resolved and limited conversation to collaborators May 12, 2021

karelz added this to the 6.0.0 milestone May 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Credentials fix - #50230

Credentials fix#50230
danmoseley merged 14 commits into
dotnet:mainfrom
aik-jahoda:jajahoda/cred-6.0

aik-jahoda commented Mar 25, 2021 •

edited

Loading

Uh oh!

ghost commented Mar 25, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 25, 2021

Uh oh!

danmoseley commented Mar 26, 2021

Uh oh!

elinor-fung commented Mar 29, 2021

Uh oh!

aik-jahoda commented Mar 30, 2021

Uh oh!

aik-jahoda commented Apr 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

aik-jahoda commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Mar 25, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 25, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

danmoseley commented Mar 26, 2021

Uh oh!

elinor-fung commented Mar 29, 2021

Uh oh!

aik-jahoda commented Mar 30, 2021

Uh oh!

aik-jahoda commented Apr 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aik-jahoda commented Mar 25, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.