Skip to content

[main] Update dependencies from dotnet/arcade#18213

Merged
mmitche merged 10 commits into
mainfrom
darc-main-1f26663a-23d4-4815-9ae9-76ca1b343fcb
Jan 17, 2024
Merged

[main] Update dependencies from dotnet/arcade#18213
mmitche merged 10 commits into
mainfrom
darc-main-1f26663a-23d4-4815-9ae9-76ca1b343fcb

Conversation

@dotnet-maestro
Copy link
Copy Markdown

@dotnet-maestro dotnet-maestro Bot commented Jan 11, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 7787dd03-cbf4-4297-391c-08d8e9750bf8
  • Build: 20240116.3
  • Date Produced: January 16, 2024 11:53:17 PM UTC
  • Commit: d5ee27a55ec6383c29790f3ec666e7c87f7da022
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
4f14391 
…110.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24060.1 -> To Version 9.0.0-beta.24060.5
@MichaelSimons
Copy link
Copy Markdown
Member

MichaelSimons commented Jan 11, 2024

@ellahathaway - the failures look related to dotnet/arcade#14353.

@ellahathaway
Copy link
Copy Markdown
Member

ellahathaway commented Jan 11, 2024

The binlog shows Property reassignment: $(MicrosoftBclAsyncInterfacesVersion)="9.0.0-alpha.1.24054.10" (previous value: "9.0.0-alpha.1.24059.2") at /vmr/artifacts/obj/x64/Release/PackageVersions.arcade.Previous.props (6,5). I believe this is occurring because installer is downloading sdk v9.0.100-alpha.1.24055.2 which has 9.0.0-alpha.1.24054.10 versions of the dependencies.

I'm unsure how to move forward from here. @mthalman - do you have guidance on how to proceed?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
40e9e95 
…110.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24060.1 -> To Version 9.0.0-beta.24060.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
3804b17 
…112.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24060.1 -> To Version 9.0.0-beta.24062.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
ee9d925 
…112.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24060.1 -> To Version 9.0.0-beta.24062.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
3fd65f5 
…112.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24060.1 -> To Version 9.0.0-beta.24062.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
4221c14 
…115.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24060.1 -> To Version 9.0.0-beta.24065.5
@ellahathaway
Copy link
Copy Markdown
Member

ellahathaway commented Jan 16, 2024

We believe that these failures should be resolved automatically by a re-bootstrap of the VMR. @MichaelSimons, is there anything else that should be done for this PR in the meantime?

Separately, I am conducting an internal investigation into why the N-1 arcade dependencies were flagged as prebuilts (fixed in dotnet/arcade#14353) to begin with.

@MichaelSimons
Copy link
Copy Markdown
Member

MichaelSimons commented Jan 16, 2024

We believe that these failures should be resolved automatically by a re-bootstrap of the VMR. @MichaelSimons, is there anything else that should be done for this PR in the meantime?

Is there a tracking issue/pr for this? When will this be completed?

@ellahathaway
Copy link
Copy Markdown
Member

ellahathaway commented Jan 16, 2024

dotnet/source-build#3974 mentions needing to rebootstrap to fix the Alpine leg failure. I can also open another issue about reboostrapping and mention this PR.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
33f911b 
…116.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24060.1 -> To Version 9.0.0-beta.24066.3
@mmitche
Copy link
Copy Markdown
Member

mmitche commented Jan 17, 2024

Also, the arcade patches no longer apply after @NikolaMilosavljevic's change to disable the inner clone.

@ellahathaway ellahathaway mentioned this pull request Jan 17, 2024
Merged
@NikolaMilosavljevic
Copy link
Copy Markdown
Member

NikolaMilosavljevic commented Jan 17, 2024

Also, the arcade patches no longer apply after @NikolaMilosavljevic's change to disable the inner clone.

I'll remove the patch.

@NikolaMilosavljevic
Copy link
Copy Markdown
Member

NikolaMilosavljevic commented Jan 17, 2024 •
edited
Loading

Also, the arcade patches no longer apply after @NikolaMilosavljevic's change to disable the inner clone.

I'll remove the patch.

Done.

@dotnet-maestro dotnet-maestro Bot requested a review from a team as a code owner January 17, 2024 18:39
@NikolaMilosavljevic
Copy link
Copy Markdown
Member

NikolaMilosavljevic commented Jan 17, 2024 •
edited
Loading

This is now hitting package downgrade errors in arcade for Microsoft.Bcl.AsyncInterfaces and System.Text.Json. @ellahathaway I think you were tracking these, right?

cc @mthalman

@ellahathaway
Copy link
Copy Markdown
Member

ellahathaway commented Jan 17, 2024 •
edited
Loading

This is now hitting package downgrade errors in arcade for Microsoft.Bcl.AsyncInterfaces and System.Text.Json. @ellahathaway I think you were tracking these, right?

Yes. Those change have been merged in as part of dotnet/arcade#14377. Those changes have also now been applied as a patch to #18278. Waiting on approval/green build for #18278 which should unblock this PR.

@ellahathaway
Copy link
Copy Markdown
Member

ellahathaway commented Jan 17, 2024

#18278 has now been merged. That should unblock this PR.

@mmitche mmitche merged commit b9cdb4a into main Jan 17, 2024
@mmitche mmitche deleted the darc-main-1f26663a-23d4-4815-9ae9-76ca1b343fcb branch January 17, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MichaelSimons @ellahathaway @mmitche @NikolaMilosavljevic @mthalman