Skip to content

[release/3.0.1xx] Update dependencies from aspnet/AspNetCore - #5250

Merged
dotnet-maestro[bot] merged 2 commits into
release/3.0.1xxfrom
darc-release/3.0.1xx-ccee4689-c628-4e3c-accb-c4366096856e
Oct 29, 2019
Merged

[release/3.0.1xx] Update dependencies from aspnet/AspNetCore#5250
dotnet-maestro[bot] merged 2 commits into
release/3.0.1xxfrom
darc-release/3.0.1xx-ccee4689-c628-4e3c-accb-c4366096856e

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Oct 17, 2019 •
edited
Loading

Copy link
Copy Markdown

This pull request updates the following dependencies

From https://github.com/aspnet/AspNetCore

  • Build: 20191028.7
  • Date Produced: 10/29/2019 5:33 PM
  • Commit: 2c6456d4634df947e3cafd5e7dee02289dc12697
  • Branch: refs/heads/release/3.0
  • Updates:
    • dotnet-user-secrets -> 3.0.1-servicing.19528.7
    • dotnet-watch -> 3.0.1-servicing.19528.7
    • Microsoft.AspNetCore.App.Runtime.win-x64 -> 3.0.1-servicing.19528.7
    • dotnet-dev-certs -> 3.0.1-servicing.19528.7
    • Microsoft.AspNetCore.DeveloperCertificates.XPlat -> 3.0.1-servicing.19528.7

@dotnet-maestro
Update dependencies from https://github.com/aspnet/AspNetCore build 2…
43f0bd5 
…0191016.9

- Microsoft.AspNetCore.App.Runtime.win-x64 - 3.0.1-servicing.19516.9
- dotnet-watch - 3.0.1-servicing.19516.9
- dotnet-user-secrets - 3.0.1-servicing.19516.9
- dotnet-dev-certs - 3.0.1-servicing.19516.9
- Microsoft.AspNetCore.DeveloperCertificates.XPlat - 3.0.1-servicing.19516.9
@dotnet-maestro

dotnet-maestro Bot commented Oct 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_LinuxPortable_NoSuffix_Release_x64), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_14_04_Release_x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@mmitche

mmitche commented Oct 17, 2019

Copy link
Copy Markdown
Member

@wtgodbe @dougbu It looks like aspnetcore may be not building any linux runtimes after one of the changes that came in with this:

dotnet/aspnetcore@8c39137...5ceb94f

Windows installers and tar.gz files are still there. Was this intentional?

@dotnet-maestro

dotnet-maestro Bot commented Oct 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_LinuxPortable_NoSuffix_Release_x64), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_14_04_Release_x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dougbu

dougbu commented Oct 17, 2019

Copy link
Copy Markdown

Was this intentional?

No and I think this is on me. The changes to src/Installers/Debian/Directory.Build.targets and src/Installers/Rpm/Directory.Build.targets have too wide a scope. The intent was to only disable building the targeting packs. I'll send a quick PR to change things around a bit.

@dotnet-maestro

dotnet-maestro Bot commented Oct 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_LinuxPortable_NoSuffix_Release_x64), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_14_04_Release_x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dougbu dougbu mentioned this pull request Oct 17, 2019
Merged
@dougbu

dougbu commented Oct 17, 2019

Copy link
Copy Markdown

Note that until dotnet/aspnetcore#14425 is in, you'll need to pin the targeting pack versions here. We aren't enabling their build elsewhere due to the current issues.

@dotnet-maestro

dotnet-maestro Bot commented Oct 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_LinuxPortable_NoSuffix_Release_x64), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_14_04_Release_x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@nguerrera

nguerrera commented Oct 19, 2019

Copy link
Copy Markdown

The targeting pack is already pinned:
https://github.com/dotnet/core-sdk/blob/ab03d3282c3728cb5f45a70520b3618b4116d05c/eng/Version.Details.xml#L44

#5170 is pending to unpin it when you're ready

@dotnet-maestro

dotnet-maestro Bot commented Oct 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Arm_NoSuffix_Release), .NET Core core-sdk CI (build Linux Build_LinuxPortable_NoSuffix_Release_x64), .NET Core core-sdk CI (build Darwin Build_Release), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Linux Build_Arm64_Debug), .NET Core core-sdk CI (build Linux Build_Arm_Debug), .NET Core core-sdk CI (build Linux Build_Rhel_6_Debug_x64), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_28_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_27_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_arm), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_DropSuffix_Release_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dotnet-maestro
Update dependencies from https://github.com/aspnet/AspNetCore build 2…
2f1e881 
…0191028.7

- dotnet-user-secrets - 3.0.1-servicing.19528.7
- dotnet-watch - 3.0.1-servicing.19528.7
- Microsoft.AspNetCore.App.Runtime.win-x64 - 3.0.1-servicing.19528.7
- dotnet-dev-certs - 3.0.1-servicing.19528.7
- Microsoft.AspNetCore.DeveloperCertificates.XPlat - 3.0.1-servicing.19528.7
@dotnet-maestro
dotnet-maestro Bot merged commit ee22b96 into release/3.0.1xx Oct 29, 2019
@dotnet-maestro
dotnet-maestro Bot deleted the darc-release/3.0.1xx-ccee4689-c628-4e3c-accb-c4366096856e branch October 29, 2019 19:36
@nguerrera

nguerrera commented Oct 30, 2019

Copy link
Copy Markdown

@JunTaoLuo @dougbu, should I proceed with #5170 and unpin the targeting pack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmitche @dougbu @nguerrera