Skip to content

Unpin ASP.NET targeting pack for 3.0.1 servicing - #5170

Closed
nguerrera wants to merge 3 commits into
dotnet:release/3.0.1xxfrom
nguerrera:unpin-asp-ref
Closed

Unpin ASP.NET targeting pack for 3.0.1 servicing#5170
nguerrera wants to merge 3 commits into
dotnet:release/3.0.1xxfrom
nguerrera:unpin-asp-ref

Conversation

@nguerrera

Copy link
Copy Markdown

@nguerrera nguerrera added this to the 3.0.101 milestone Oct 8, 2019
@nguerrera
nguerrera requested a review from livarcocc October 8, 2019 14:18
@nguerrera

Copy link
Copy Markdown
Author

Pinging this as a note that this change will still be needed once we have good 3.0.1 ASP.NET targeting pack

@nguerrera
nguerrera requested a review from wtgodbe October 30, 2019 21:56
@nguerrera

Copy link
Copy Markdown
Author

@JunTaoLuo

@nguerrera

Copy link
Copy Markdown
Author

@mmitche

@nguerrera

Copy link
Copy Markdown
Author

Re-pinging @livarcocc for review

@nguerrera

Copy link
Copy Markdown
Author

@JunTaoLuo

   aspnetcore-targeting-pack-3.0 depends on dotnet-targeting-pack-3.0 (>= 3.0.1); however:
    Version of dotnet-targeting-pack-3.0 on system is 3.0.0-1.

The .deb for the ASP.NET tp requires version 3.0.1 of base tp, but we are keeping base tp pinned.

@dougbu

dougbu commented Nov 1, 2019

Copy link
Copy Markdown

@wtgodbe @JunTaoLuo is this now unblocked?

@nguerrera

Copy link
Copy Markdown
Author

#5450 (comment)

@nguerrera

Copy link
Copy Markdown
Author

Sorry, no, wrong branch. I'm not seeing a PR with a build with the fix for above...

@mmitche

mmitche commented Nov 1, 2019

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nguerrera

Copy link
Copy Markdown
Author

Did we get a new ASP.NET with the change to pin the ref pack, else this will fail again.

@mmitche

mmitche commented Nov 1, 2019

Copy link
Copy Markdown
Member

Did we get a new ASP.NET with the change to pin the ref pack, else this will fail again.

Checking

@mmitche

mmitche commented Nov 1, 2019

Copy link
Copy Markdown
Member

No. The last time an aspnetcore officail build passed was tueday

@JunTaoLuo

Copy link
Copy Markdown

There should be an update available since AspNetCore finished building. Does there need to be a manual trigger on this PR to ingest the new build?

@nguerrera

Copy link
Copy Markdown
Author

I've incorporated this into #5526 that ingests the stabilized build

@nguerrera nguerrera closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants